Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tax on donation tickets #3260

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 11, 2019

Screenshot
Screenshot 2019-07-11 at 1 15 45 PM

22% tax rate (separate fee on top of price)


Fixes #3259

Short description of what this resolves:

Resolves the issue with the resultant negative tax popping up due to the non-updation of the ticket price in the computed property

Changes proposed in this pull request:

  • Added price as a watchable property to update the computed property

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 11, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: Fix tax on donation tickets fix: Fix negatice donation tickets Jul 11, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: Fix negatice donation tickets fix: Fix tax on donation tickets Jul 11, 2019
@niranjan94 niranjan94 merged commit f83afc8 into fossasia:development Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with tax on donations(separate fee)
2 participants