Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Order Summary making similar to EventBrite #3280

Merged
merged 14 commits into from
Aug 13, 2019
Merged

feat: Order Summary making similar to EventBrite #3280

merged 14 commits into from
Aug 13, 2019

Conversation

kushthedude
Copy link
Member

Fixes #2993

Please See #3079 for Screenshots and discussion

Changes Made in This PR -:

  • Modifies the Summary Table for Free tickets or Discounted Tickets with Net Order Value Resulting in Zero.
  • Hide Discount Column if the discount is not applied.
  • Subtotal includes the Tax for each ticket now

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jul 14, 2019
@kushthedude kushthedude mentioned this pull request Jul 14, 2019
Closed
5 tasks
mrsaicharan1
mrsaicharan1 reviewed Jul 30, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude I was able to see parts of everything over there. Could you please add a final screenshot? Thanks!

@kushthedude
Copy link
Member Author

Screenshot :

image

image

image

image

@kushthedude
Copy link
Member Author

@mrsaicharan1 @shreyanshdwivedi @uds5501 Please Review

@kushthedude
Copy link
Member Author

@CosmicCoder96 Please Review

@kushthedude
Copy link
Member Author

@CosmicCoder96 I think we are good to go for this now?

@kushthedude kushthedude requested review from mrsaicharan1, shreyanshdwivedi and uds5501 and removed request for shreyanshdwivedi and uds5501 August 13, 2019 12:48
@kushthedude
Copy link
Member Author

@uds5501 @mrsaicharan1 Please Review

@kushthedude kushthedude merged commit c4b391e into fossasia:development Aug 13, 2019
@kushthedude kushthedude deleted the summary branch November 8, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@niranjan94 niranjan94 Awaiting requested review from niranjan94

@uds5501 uds5501 Awaiting requested review from uds5501

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order Summary Improvements and Making it similar to EventBrite
4 participants
@kushthedude @abhinavk96 @mrsaicharan1 @shreyanshdwivedi