-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add billing information in order view page #3297
Conversation
@shreyanshdwivedi @mrsaicharan1 @niranjan94 @CosmicCoder96 |
return this.data.attendees; | ||
} | ||
|
||
@computed('data.amount', 'data.isBillingEnabled') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, Use like this
@or('data.amount','data,isBillingEnabled')
showBillingInfo;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushthedude it doesn't work this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushthedude is right. Thats the right way to do it.
If it doesn't work, maybe you're doing something wrong. You can push the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niranjan94 Alright, taking a look.
f70527e
to
9e26cdf
Compare
9e26cdf
to
4bbba6c
Compare
return this.data.attendees; | ||
} | ||
|
||
@computed('data.amount', 'data.isBillingEnabled') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushthedude is right. Thats the right way to do it.
If it doesn't work, maybe you're doing something wrong. You can push the code.
@kushthedude @niranjan94 I have pushed the code with correct implementation. The thing which i was doing wrong at my part was using |
980ddd2
to
c86fa6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uds5501 travis is failing
@Anupam-dagar It's passing now. @shreyanshdwivedi @mrsaicharan1 Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uds5501 Please update the branch
Fixes #3295
Short description of what this resolves:
It implements usage of shows billing details for paid orders.
Changes proposed in this pull request:
attendee-list
component according to ES6 standardsChecklist
development
branch.