Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of gender field #3308

Merged
merged 3 commits into from
Jul 30, 2019
Merged

fix: rendering of gender field #3308

merged 3 commits into from
Jul 30, 2019

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Jul 26, 2019

Fixes #3307

Short description of what this resolves:

  • Fixing the rendering of if clause for gender fields

Screenshot

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude kushthedude marked this pull request as ready for review July 26, 2019 14:12
@kushthedude kushthedude changed the title Fixing rendering of gender field fix: rendering of gender field Jul 26, 2019
@auto-label auto-label bot added the fix label Jul 26, 2019
@kushthedude kushthedude requested a review from mrsaicharan1 July 28, 2019 14:25
@fossasia fossasia deleted a comment from kushthedude Jul 28, 2019
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the server-side changes been merged?

@kushthedude
Copy link
Member Author

kushthedude commented Jul 28, 2019 via email

@mrsaicharan1
Copy link
Member

No need for server change @mrsaicharan1 only issue was it was placed in wrong parent if block for text type and on server it was changed to select .

I was asking for that very change. 👍

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 Please Review

@uds5501 uds5501 merged commit c9445bb into fossasia:development Jul 30, 2019
@kushthedude
Copy link
Member Author

@uds5501 Please make sure you do Squash and Merge so that multiple commits don't associate with a single PR. 😅

@kushthedude kushthedude deleted the 7 branch July 30, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Form : Buggy Fields in custom forms
4 participants