Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement a tick box for organizers/admin to override Email #3352

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 3, 2019

Fixes #2953

Short description of what this resolves:

When a speaker registers they have to enter an email. It must be possible to override this requirement for organizers/admins

Screenshot_2019-08-03 Create session Speakers cfs Events Open Event

Screenshot_2019-08-03 Create session Sessions cfs Events Open Event

Changes proposed in this pull request:

  • Adds a checkbox to override email while creating speaker from event dashboard

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the code is repetitive, is it possible to shift it to a mixin?

@shreyanshdwivedi
Copy link
Member Author

@CosmicCoder96 @uds5501 please review

@shreyanshdwivedi
Copy link
Member Author

@kushthedude @CosmicCoder96 pleaae review

@fossasia fossasia deleted a comment Aug 8, 2019
@kushthedude kushthedude merged commit 1e1616c into fossasia:development Aug 8, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the emailOverride branch August 20, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a tick box for organizers/admin to override Email requirement
4 participants