Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paytm to create event and order-form page #3400

Merged
merged 4 commits into from
Aug 20, 2019

Conversation

shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 13, 2019

Fixes #3388

Changes proposed in this pull request:

  • It adds paytm to create event and order-form page

Create Event
Screenshot_2019-08-13 Basic Details Edit Event Paytm Events Open Event

New Order
Screenshot_2019-08-13 New Order -a5185ec5-02ab-424a-9044-48d0edf25d37 Orders Open Event

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's incomplete as soon as organiser select Accept By PayTM, A field should or button should pop-up to connect with PayTM, As done in Stripe.

app/models/setting.js Outdated Show resolved Hide resolved
@shreyanshdwivedi
Copy link
Member Author

@kushthedude as discussed with @uds5501 @mrsaicharan1 we are starting by accepting payment to current admin's account to see if everything works initially.
Then we'll shift to accept organizer's account and connect it later. I hope this makes sense

@mrsaicharan1
Copy link
Member

It's incomplete as soon as organiser select Accept By PayTM, A field should or button should pop-up to connect with PayTM, As done in Stripe.

Every payment gateway has its own unique workflow. The other implementation details can be looked at afterwards as this is a sub issue. This is fine.

@uds5501
Copy link
Contributor

uds5501 commented Aug 20, 2019

@shreyanshdwivedi Please take a look at Travis?

@shreyanshdwivedi
Copy link
Member Author

@uds5501 @mrsaicharan1 @kushthedude @CosmicCoder96 it was a random fail. Please have a look

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mrsaicharan1 mrsaicharan1 merged commit 11f0ded into fossasia:development Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PayTM as a payment option on order checkout page
4 participants