Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Admin Sessions State sort #3461

Merged
merged 4 commits into from
Aug 26, 2019
Merged

fix: Admin Sessions State sort #3461

merged 4 commits into from
Aug 26, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3460

@kushthedude kushthedude requested a review from abhinavk96 August 21, 2019 21:43
@auto-label auto-label bot added the fix label Aug 21, 2019
@kushthedude
Copy link
Member Author

@CosmicCoder96 Please merge

shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks fine now. As status is defined on FE and server has state key that's why it wasn't working

@kushthedude kushthedude requested review from abhinavk96, mrsaicharan1 and uds5501 and removed request for abhinavk96, uds5501 and mrsaicharan1 August 23, 2019 07:14
@uds5501
Copy link
Contributor

uds5501 commented Aug 23, 2019

@kushthedude Will pull the changes and test tonight.

uds5501
uds5501 approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushthedude
Copy link
Member Author

@mrsaicharan1 please review

@abhinavk96 abhinavk96 merged commit 2724eee into fossasia:development Aug 26, 2019
@kushthedude kushthedude deleted the schem branch November 8, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@abhinavk96 abhinavk96 Awaiting requested review from abhinavk96

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin Session: Sort using State is not working
4 participants
@kushthedude @uds5501 @shreyanshdwivedi @abhinavk96