Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed alipay workflow & naming #3465

Merged
merged 2 commits into from
Aug 22, 2019
Merged

fix: Fixed alipay workflow & naming #3465

merged 2 commits into from
Aug 22, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Aug 22, 2019 •
edited
Loading

Fixes #3464

Short description of what this resolves:

Due to computed properties which were named incorrectly, the alipay workflow was buggy. Now, it functions as expected.

Changes proposed in this pull request:

  • Fixed naming conventions for controller actions to make it compatible with server schema

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Aug 22, 2019
@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi @kushthedude I can confirm that the workflow is fixed with this. Tested properly.

uds5501
uds5501 approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@uds5501 uds5501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the keys match with the ones at server now. It should work after this change.

shreyanshdwivedi
shreyanshdwivedi approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kushthedude kushthedude merged commit f87d084 into fossasia:development Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alipay naming convention bugs
4 participants
@mrsaicharan1 @uds5501 @shreyanshdwivedi @kushthedude