Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link checkout modals to server endpoints #3476

Merged
merged 2 commits into from
Aug 26, 2019
Merged

feat: link checkout modals to server endpoints #3476

merged 2 commits into from
Aug 26, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Aug 24, 2019

Fixes #3475

Short description of what this resolves:

Links modals to the server points asynchronously.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@uds5501 uds5501 mentioned this pull request Aug 24, 2019
Merged
5 tasks
Anupam-dagar
Anupam-dagar approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Still better to wait for other reviews.

@abhinavk96 abhinavk96 merged commit 80a8416 into fossasia:development Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@Anupam-dagar Anupam-dagar Anupam-dagar approved these changes

@kushthedude kushthedude kushthedude approved these changes

@mrsaicharan1 mrsaicharan1 Awaiting requested review from mrsaicharan1

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link checkout modals to server endpoints
4 participants
@uds5501 @abhinavk96 @Anupam-dagar @kushthedude