feat: Removing session names from modal #3515
Conversation
|
I tried simple links, they were looking poor thats why I used labels. |
kushthedude
requested review from
mariobehling
and removed request for
mariobehling
|
@iamareebjamal @uds5501 Please review |
|
@prateekj117 Please review PRs to get them merged |
|
|
@iamareebjamal Not sure about the UI, everything else LGTM. |
Plain links were looking way to poor, also it were degrading the way we have designed the public page hence I use ui banner |
|
Why are they each on their own line? Why not make them inline-block so they don't occupy so much vertical space |
Various session names have different length, making them inline wont make them utilise a same amount of space due to which some row will have 2-3 sessio and other would have 4-5. You can check at netlify deployment it looks quite good in using😅 |
kushthedude
requested review from
iamareebjamal and
mariobehling
and removed request for
abhinavk96,
iamareebjamal and
mariobehling
|
URL for testing? |
|
Netlify deployment is there.
…On Mon, 25 Nov, 2019, 15:01 Areeb Jamal, ***@***.***> wrote:
URL for testing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3515?email_source=notifications&email_token=AKQMTLWU5PIEICNIDJFSCIDQVOLN5A5CNFSM4IUS2CI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBXH6I#issuecomment-558068729>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXL3YCJK3LS7XGIDLTQVOLN5ANCNFSM4IUS2CIQ>
.
|
|
Yes, but for which event, which page? |
|
You will have to login to check the same, as the speaker will be able to
see his sessions. I would be able to give a gif for the following.
…On Mon, 25 Nov, 2019, 15:10 Areeb Jamal, ***@***.***> wrote:
Yes, but for which event, which page?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3515?email_source=notifications&email_token=AKQMTLRGU7UDCIWMSP5T7FDQVOMSRA5CNFSM4IUS2CI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBYGRQ#issuecomment-558072646>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXUPJL3GKUXV427PATQVOMSRANCNFSM4IUS2CIQ>
.
|
|
Tell me which one looks better? |
|
Cool will be making inline asap
…On Mon, 25 Nov, 2019, 15:18 Areeb Jamal, ***@***.***> wrote:
[image: Screenshot_2019-11-25_15-15-58]
<https://user-images.githubusercontent.com/3874064/69529731-d322b680-0f96-11ea-9086-98d2fcd9ae3d.png>
[image: Screenshot_2019-11-25_15-18-07]
<https://user-images.githubusercontent.com/3874064/69529730-d322b680-0f96-11ea-941b-a091988a3ec2.png>
Tell me which one looks better?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3515?email_source=notifications&email_token=AKQMTLQ7RTYPZB3XBS3TYA3QVONP5A5CNFSM4IUS2CI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBY6OI#issuecomment-558075705>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLRYO5EJCSBHLAC4CM3QVONP5ANCNFSM4IUS2CIQ>
.
|
|
@iamareebjamal There is a bug in this approach. |
|
What's the bug? |
|
When new speaker registers he is not redirected to correct route
…On Mon, 25 Nov, 2019, 18:17 Areeb Jamal, ***@***.***> wrote:
What;s the bug?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3515?email_source=notifications&email_token=AKQMTLVVOGYXULQQV7KFNQ3QVPCO3A5CNFSM4IUS2CI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCIXGA#issuecomment-558140312>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLVDBRN7YU55IBIA7VLQVPCO3ANCNFSM4IUS2CIQ>
.
|
kushthedude
changed the title
|
|
kushthedude
changed the title
|
@iamareebjamal Please review |
kushthedude
requested review from
uds5501 and
iamareebjamal
and removed request for
iamareebjamal and
mariobehling
Fixes #3514
Screenshots :