Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update .env.example to run server on heroku #3531

Merged
merged 2 commits into from
Sep 19, 2019
Merged

fix: update .env.example to run server on heroku #3531

merged 2 commits into from
Sep 19, 2019

Conversation

Dilshaad21
Copy link
Member

@Dilshaad21 Dilshaad21 commented Sep 19, 2019 •
edited
Loading

Fixes #3530

Short description of what this resolves:

The link to the open-event-server (API_HOST) is updated to connect to the server at heroku.

Changes proposed in this pull request:

API_HOST in .env.example updated from http://localhost:5000 --> https://open-event-api-dev.herokuapp.com/

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Dilshaad21 Dilshaad21 changed the title updated .env.example to run server on heroku fix:updated .env.example to run server on heroku Sep 19, 2019
@auto-label auto-label bot added the fix label Sep 19, 2019
iamareebjamal
iamareebjamal reviewed Sep 19, 2019
View reviewed changes
.env.example Outdated
@@ -1,3 +1,3 @@
GOOGLE_API_KEY="Sample Key"
API_HOST=http://127.0.0.1:5000
API_HOST=https://open-event-api-dev.herokuapp.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the trailing slash

@iamareebjamal iamareebjamal changed the title fix:updated .env.example to run server on heroku fix: update .env.example to run server on heroku Sep 19, 2019
@abhinavk96 abhinavk96 merged commit 3d6feec into fossasia:development Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the default API URL in .env.example for beginners
3 participants
@Dilshaad21 @iamareebjamal @abhinavk96