-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: event sort by name to actually sort by name #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do it in a couple of minutes
I think you got the wrong idea, changing the valuepath
wont fix the issue. After change of ValuePath
your record and extraRecords have been changes too, which will break every other funcnality associated with property of valuePath
.
See how Ember-Tables
have been implemented across the web-app
and complete your PR properly.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are on the right track, You also need to change the actions which are binded with the record.
What actions are you talking about? It seems that all actions are working as expected. There's just one test failing, regarding the event table |
Fixes #3499
This PR will resolve #3499
Short description of what this resolves:
Checklist
development
branch.Not Applicable