Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event sort by name to actually sort by name #3552

Merged
merged 6 commits into from
Dec 5, 2019
Merged

fix: event sort by name to actually sort by name #3552

merged 6 commits into from
Dec 5, 2019

Conversation

JoaoJesus94
Copy link
Contributor

@JoaoJesus94 JoaoJesus94 commented Oct 11, 2019

Fixes #3499
This PR will resolve #3499

Short description of what this resolves:

  • Event list will be actually sorted by name and not by id

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes

Not Applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do it in a couple of minutes

I think you got the wrong idea, changing the valuepath wont fix the issue. After change of ValuePath your record and extraRecords have been changes too, which will break every other funcnality associated with property of valuePath.
See how Ember-Tables have been implemented across the web-app and complete your PR properly.
Thanks

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on the right track, You also need to change the actions which are binded with the record.

@JoaoJesus94
Copy link
Contributor Author

JoaoJesus94 commented Oct 17, 2019

You are on the right track, You also need to change the actions which are binded with the record.

What actions are you talking about? It seems that all actions are working as expected. There's just one test failing, regarding the event table

@kushthedude kushthedude changed the title fix(Event sort): Fix event sort by name to actually sort by name fix: event sort by name to actually sort by name Dec 5, 2019
@auto-label auto-label bot added the fix label Dec 5, 2019
@iamareebjamal iamareebjamal merged commit e7929ff into fossasia:development Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Events are getting sorted by ID not their name.
3 participants