Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hotfix for non-rendering paymentCurrencies #3557

Merged
merged 1 commit into from
Oct 16, 2019
Merged

fix: Hotfix for non-rendering paymentCurrencies #3557

merged 1 commit into from
Oct 16, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3556

@iamareebjamal
Copy link
Member

I can't access the deployment. Add a before/after screenshot?

@kushthedude
Copy link
Member Author

After :
Screenshot 2019-10-16 at 3 22 34 AM

Also @iamareebjamal since I am not sure which currency was used in the following event. It wont be solved until a new release is made.

@iamareebjamal
Copy link
Member

You can change the API_URL locally to api.eventyay.com and see if it fixes the issue

@kushthedude
Copy link
Member Author

You can change the API_URL locally to api.eventyay.com and see if it fixes the issue

Issue Solved :
Screenshot 2019-10-16 at 4 15 55 AM

Thanks for this nice little trick

@kushthedude
Copy link
Member Author

But what's more interesting is that we don't have IDR in the paymentsDictionary then how was he able to enter IDR into the dropdown?

@kushthedude
Copy link
Member Author

@iamareebjamal

@iamareebjamal
Copy link
Member

Again, most probably because JS validations mean nothing?

@kushthedude
Copy link
Member Author

@iamareebjamal Please merge. Also there is a need for new release for FE after this commit.

@iamareebjamal
Copy link
Member

It's not that big a bug to warrant a release. We need to fix #3555 before

@iamareebjamal iamareebjamal merged commit 178a7dd into fossasia:development Oct 16, 2019
@kushthedude kushthedude deleted the tick branch December 19, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Ticket List: Unability of rendering of Currency Symbol
2 participants