fix: Ticket dashboard table css overflow on small screens #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a GIF for the same, Its difficult to understand this change from the SS ? |
|
@kushthedude here is the gif : |
Use properties |
snitin315
force-pushed
the
development
branch
from
89e5926 to
9bc7d80
Compare
|
kushthedude
reviewed
Nov 4, 2019
| <div class="ui header"> | ||
| {{t 'Order Summary'}} | ||
| <span class="sub header"> | ||
| {{t 'By order status'}} | ||
| </span> | ||
| </div> | ||
|
|
kushthedude
reviewed
Nov 5, 2019
| <div class="row"> | ||
| <table class="ui stackable celled unstackable table"> | ||
| <div class="row x-scrollable"> | ||
| <table class="ui stackable celled unstackable table" > |
There was a problem hiding this comment.
no need for extra space in here
snitin315
force-pushed
the
development
branch
from
6a50944 to
1cac947
Compare
snitin315
force-pushed
the
development
branch
from
1cac947 to
469b8c3
Compare
|
@kushthedude fixed #3605 in this PR as well. below is the corresponding screenshot.Please review
|
kushthedude
approved these changes
Nov 8, 2019
|
Thanks a lot for this PR. Please help to get some important issues out of the way in this project. We have labeled these issues here: https://github.com/fossasia/open-event-frontend/issues?q=is%3Aissue+is%3Aopen+label%3A%22Priority%3A+High%22 Our goal is to focus on these issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3589 #3605
Short description of what this resolves:
fixes the ticket dashboard Table CSS Overflow on Small Device Screens.
Also fixes the manage events dashboard search-box overflow on small screen devices :
Changes proposed in this pull request:
I have fixed it by setting the css overflow property to scroll.
Checklist
developmentbranch.