fix: ticketing system buttons alignment #3614
Conversation
|
Show ss in large screen ! |
|
|
It looks too poor, make it as before for large screen
…On Sun, 10 Nov, 2019, 16:51 Nitin Kumar, ***@***.***> wrote:
Show ss in large screen !
[image: Screenshot from 2019-11-10 16-50-28]
<https://user-images.githubusercontent.com/46647141/68543223-4eeb0380-03da-11ea-8f4a-e10759c5ee73.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3614?email_source=notifications&email_token=AKQMTLT2JQNXHU5PDD6A6G3QS7VDXA5CNFSM4JLHPPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDU25XI#issuecomment-552185565>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQ4XUMVXCJOTGRVEFDQS7VDXANCNFSM4JLHPPPA>
.
|
snitin315
force-pushed
the
development
branch
from
e967334 to
75c86bb
Compare
|
snitin315
force-pushed
the
development
branch
from
75c86bb to
f543b6d
Compare
|
Dont change layout for the widescreen, Make changes only for |
snitin315
force-pushed
the
development
branch
from
d32fdeb to
7addb29
Compare
@kushthedude Done , Now i have made changes only for the |
snitin315
force-pushed
the
development
branch
from
5e084b0 to
8465c60
Compare
There was a problem hiding this comment.
@kushthedude , How about these changes, edited just 3 lines.
snitin315
changed the title
| @@ -189,14 +189,14 @@ | |||
| </h3> | |||
| {{/if}} | |||
| </div> | |||
| <button type="button" class="ui blue small button" {{action 'addTicket' 'free' data.event.tickets.length}}> | |||
| <button type="button" class="ui blue {{if device.isMobile 'field fluid'}} small button" {{action 'addTicket' 'free' data.event.tickets.length}}> | |||
There was a problem hiding this comment.
I think field fluid fluid should work. Else its LGTM 👍
There was a problem hiding this comment.
@kushthedude , Without field there is no margin between the buttons .
| @@ -189,14 +189,14 @@ | |||
| </h3> | |||
| {{/if}} | |||
| </div> | |||
| <button type="button" class="ui blue small button" {{action 'addTicket' 'free' data.event.tickets.length}}> | |||
| <button type="button" class="ui blue {{if device.isMobile 'field fluid'}} small button" {{action 'addTicket' 'free' data.event.tickets.length}}> | |||
There was a problem hiding this comment.
Why is the block inserted in the middle of class? Move it to the end
There was a problem hiding this comment.
@iamareebjamal Done, Moved the block to the end. Please review.
snitin315
force-pushed
the
development
branch
from
4726ac9 to
dafa388
Compare
Fixes #3603
Short description of what this resolves:
fixes the weird alignment of The ticketing system buttons(i.e. free ticket, paid ticket ,donation ticket) on the create event page on small screens.
Changes proposed in this pull request:
Checklist
developmentbranch.