Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change open-event to eventyay for small screens #3626

Closed
wants to merge 3 commits into from
Closed

fix: change open-event to eventyay for small screens #3626

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39df8ac
changing eventyay to {{settings.appName}}
himanshu010 Nov 18, 2019
7bf244c
changed config.appname to eventyay
himanshu010 Nov 21, 2019
d21fbbc
Changed to config.appname
himanshu010 Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/components/nav-bar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<i class="large content icon"></i>
</a>
{{#link-to 'index' class='item' activeClass=''}}
<div class="ui header small text">{{config.appName}}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use config please. Settings is asynchronous so it'll take time to show up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using settings for various importing the name and tagline for the appName and various other input we need.
Also setting is globally injected into app as services, So it should not make much of a difference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also setting is globally injected into app as services, So it should not make much of a difference.

I don't know any of that. I know that an AJAX request is made for that. This thinking has lead to how slow the app is.

And if settings are meant to be used here, why is there an option of config.appName?

<div class="ui header small text">{{settings.appName}}</div>
{{/link-to}}
<div class="right menu nav-bar">
{{#if session.isAuthenticated}}
Expand Down