Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove blue background from export drop-down #3629

Merged
merged 3 commits into from
Nov 24, 2019
Merged

fix: remove blue background from export drop-down #3629

merged 3 commits into from
Nov 24, 2019

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Nov 16, 2019 •
edited
Loading

Fixes #3628
Screenshot from 2019-11-16 22-48-52

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Nov 16, 2019
kushthedude
kushthedude reviewed Nov 17, 2019
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the title to Removing blue background or something like that. Current title is too vivid to guess the change.

@maze-runnar maze-runnar changed the title fix: drop-down is looking proper in mobile too fix: removing blue background from drop-down Nov 17, 2019
@iamareebjamal iamareebjamal changed the title fix: removing blue background from drop-down fix: remove blue background from export drop-down Nov 24, 2019
@iamareebjamal iamareebjamal merged commit c4607c2 into fossasia:development Nov 24, 2019
@maze-runnar maze-runnar deleted the patch-10 branch January 12, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushthedude kushthedude kushthedude approved these changes

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export as drop down is not proper in mobile view
3 participants
@maze-runnar @kushthedude @iamareebjamal