feat: Billing Information Enhancements and Updations #3654
Conversation
|
@iamareebjamal Please check, To be merged after: fossasia/open-event-server#6447 |
kushthedude
changed the title
|
@iamareebjamal Removed duplications , Please give it a look |
kushthedude
requested review from
iamareebjamal
and removed request for
iamareebjamal
|
@iamareebjamal UPdated. |
|
|
||
| isBillingNotMandatory: computed('event', function() { | ||
| return !this.event.isBillingInfoMandatory; | ||
| }), |
There was a problem hiding this comment.
Why can't you just use not in the template
There was a problem hiding this comment.
For or, I will need to use ember arithmentic helper add-on which cost more then the js checking. I will use the following isBillingNotMandaotry in the template`
There was a problem hiding this comment.
Not talking about or. I'm talking about not
| @@ -0,0 +1,41 @@ | |||
| <div class="field"> | |||
There was a problem hiding this comment.
Can we move it back to the template now?
There was a problem hiding this comment.
It looks more organised since its a just a tool which is needed for the order-form, I dont see any issue in moving it to a widget?
Fixes #3518