fix: Remove date and time validations #3672
Conversation
|
@maze-runnar Please test and report if you encounter those errors after this too . |
it's not encountering any problem now but in one case it is not setting time properly . |
|
Private video.
…On Fri, 29 Nov, 2019, 17:53 Sundaram Dubey, ***@***.***> wrote:
@maze-runnar <https://github.com/maze-runnar> Please test and report if
you encounter those errors after this too .
it's not encountering any problem now but in one case it is not setting
time properly .
https://youtu.be/UdaeOunGVBU
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLQD44ZIQ2FVM5TOOQLQWECU3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOXOYY#issuecomment-559773539>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLTZKBI2XXLYFWT5QQ3QWECU3ANCNFSM4JS3S7GA>
.
|
sorry , made it public now . |
|
Can you please tell how do i get the invalid date , I cant get it using the
widget?
On Fri, 29 Nov, 2019, 18:15 Sundaram Dubey, <notifications@github.com>
wrote:
… Private video.
… <#m_7640677229099065855_>
On Fri, 29 Nov, 2019, 17:53 Sundaram Dubey, *@*.***> wrote: @maze-runnar
<https://github.com/maze-runnar> https://github.com/maze-runnar Please
test and report if you encounter those errors after this too . it's not
encountering any problem now but in one case it is not setting time
properly . https://youtu.be/UdaeOunGVBU — You are receiving this because
you authored the thread. Reply to this email directly, view it on GitHub <
#3672 <#3672>?email_source=notifications&email_token=AKQMTLQD44ZIQ2FVM5TOOQLQWECU3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOXOYY#issuecomment-559773539>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLTZKBI2XXLYFWT5QQ3QWECU3ANCNFSM4JS3S7GA
.
sorry , made it public now .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLWDSL54AN4RNWW2HMLQWEFF3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOYXUI#issuecomment-559778769>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLVSEXVT7G5PKBWKATTQWEFF3ANCNFSM4JS3S7GA>
.
|
you reprodoced the error ? |
|
Nope
On Fri, 29 Nov, 2019, 18:28 Sundaram Dubey, <notifications@github.com>
wrote:
… Can you please tell how do i get the invalid date , I cant get it using
the widget? On Fri, 29 Nov, 2019, 18:15 Sundaram Dubey,
***@***.*** wrote:
… <#m_-108322966264842058_>
Private video. … <#m_7640677229099065855_> On Fri, 29 Nov, 2019, 17:53
Sundaram Dubey, *@*.***> wrote: @maze-runnar
<https://github.com/maze-runnar> https://github.com/maze-runnar
https://github.com/maze-runnar Please test and report if you encounter
those errors after this too . it's not encountering any problem now but in
one case it is not setting time properly . https://youtu.be/UdaeOunGVBU —
You are receiving this because you authored the thread. Reply to this email
directly, view it on GitHub < #3672
<#3672> <#3672
<#3672>>?email_source=notifications&email_token=AKQMTLQD44ZIQ2FVM5TOOQLQWECU3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOXOYY#issuecomment-559773539>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLTZKBI2XXLYFWT5QQ3QWECU3ANCNFSM4JS3S7GA
. sorry , made it public now . — You are receiving this because you
authored the thread. Reply to this email directly, view it on GitHub <
#3672 <#3672>?email_source=notifications&email_token=AKQMTLWDSL54AN4RNWW2HMLQWEFF3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOYXUI#issuecomment-559778769>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLVSEXVT7G5PKBWKATTQWEFF3ANCNFSM4JS3S7GA
.
you reprodoced the error ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLXOQ47RJS2HKURF5ETQWEGW3A5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZRBY#issuecomment-559782023>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLTHUYNJFGF6KI65UF3QWEGW3ANCNFSM4JS3S7GA>
.
|
|
in the start* field , erase the previous existing time and click outside of box . Then error will produce and won't go without refreshing the page . |
|
Still not reproducible?
…On Fri, 29 Nov, 2019, 18:38 Sundaram Dubey, ***@***.***> wrote:
in the start* field , erase the previous existing time and click outside
of box . Then error will produce and won't go without refreshing the page .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLUIM3FYIUPEAGSXEKTQWEH4VA5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFO2FLY#issuecomment-559784623>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLW6CZZPD7K5YBU6P5LQWEH4VANCNFSM4JS3S7GA>
.
|
|
i am creating this error with these steps every time 😕 |
|
The event wizard is not showing any error in any other case by any step , this is a only problem . |
kushthedude
requested review from
dblueman and
iamareebjamal
and removed request for
dblueman
|
I think this is not common for anyone to produce error in this way 😄 and beside this it is working fine . |
|
Please remove only for the case mentioned in the issue and add a TODO comment to add it later |
|
If thats the case here, then it should be happening in every validation.
All the three time rules implied in session speaker, basic detail and
discount code are same. Hence, removing from any one doesn't make sense
…On Fri, 29 Nov, 2019, 19:49 Areeb Jamal, ***@***.***> wrote:
Please remove only for the case mentioned in the issue and add a TODO
comment to add it later
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLSI6GJHMNLKQV6I4T3QWEQGFA5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFO7CFY#issuecomment-559804695>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLRGRT2ZM5F2CXWHVWTQWEQGFANCNFSM4JS3S7GA>
.
|
|
Yes it does not, but we are creating a workaround and not a fix. Anyway, remove all but add a comment |
|
@iamareebjamal Please merge |
|
Done
…On Sat, 30 Nov, 2019, 02:36 Areeb Jamal, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/components/forms/events/view/create-discount-code.js
<#3672 (comment)>
:
> @@ -22,11 +21,7 @@ export default Component.extend(FormMixin, {
return false;
};
- window.$.fn.form.settings.rules.checkDates = () => {
- let startDatetime = moment(this.get('data.validFrom'));
- let endDatetime = moment(this.get('data.validTill'));
- return (endDatetime.diff(startDatetime, 'minutes') > 0);
- };
+ // Removing the Discount Code Time Validations due to the weird and buggy behaviour. Will be restored once a perfect solution is found. Please check issue: #3667
Add TODO:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3672?email_source=notifications&email_token=AKQMTLTWOM2XKSRLKTQXKL3QWF74DA5CNFSM4JS3S7GKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNOODIQ#pullrequestreview-324854178>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLWSXEVIZA42OZDQDITQWF74DANCNFSM4JS3S7GA>
.
|
iamareebjamal
changed the title
Fixes #3667