chore: migrating cropper-modal to ES6 #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maze-runnar
changed the title
|
@uds5501 @kushthedude please review . |
kushthedude
reviewed
Dec 4, 2019
| onVisible() { | ||
| let viewport = {}; | ||
| let factor = 150; | ||
| let factor = 750; |
kushthedude
reviewed
Dec 4, 2019
|
Fix build |
. |
|
@kushthedude please review and merge . |
kushthedude
previously approved these changes
Dec 21, 2019
|
@kushthedude update the branch again please and see if it's good to merge after that |
Its on hold because of the Croppie PR. ONCE the Croppie one is merged here will be conflicts hence putted on hold. |
|
@maze-runnar Resolve conflicts |
maze-runnar
dismissed stale reviews from kushthedude and uds5501
via
befd0a6
uds5501
previously approved these changes
Dec 24, 2019
kushthedude
suggested changes
Dec 24, 2019
| this.onVisible(); | ||
| }, | ||
| cropImage() { | ||
| this.$('img').croppie('result', { type: 'base64', size: 'original', quality: 1, format: 'jpeg' }).then(result => { |
There was a problem hiding this comment.
You removed the very change you made in the RECENT PR
kushthedude
reviewed
Dec 24, 2019
Co-Authored-By: Kush Trivedi <kushthedude@gmail.com>
kushthedude
approved these changes
Dec 25, 2019
iamareebjamal
approved these changes
Dec 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3618
Checklist
developmentbranch.