Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Email Override possible for all users #3701

Merged
merged 4 commits into from
Dec 22, 2019
Merged

fix: Email Override possible for all users #3701

merged 4 commits into from
Dec 22, 2019

Conversation

kushthedude
Copy link
Member

Fixes #3506

@auto-label auto-label bot added the fix label Dec 14, 2019
iamareebjamal
iamareebjamal reviewed Dec 14, 2019
View reviewed changes
app/routes/public.js Outdated Show resolved Hide resolved
@iamareebjamal
Copy link
Member

Also, not just the owner, but also organizers should be given this option?

@kushthedude
Copy link
Member Author

Also, not just the owner, but also organizers should be given this option?

Cool, I will the change the corresponding changes for same 👍 , But @iamareebjamal I don't think it should be displayed to co-organisers too ? #3418 (comment)

@iamareebjamal
Copy link
Member

iamareebjamal commented Dec 14, 2019 •
edited
Loading

Issue mentions only organizers

@kushthedude kushthedude changed the title fix: Email Override possible for all users [wip]: Email Override possible for all users Dec 15, 2019
@auto-label auto-label bot removed the fix label Dec 15, 2019
@kushthedude kushthedude changed the title [wip]: Email Override possible for all users fix: Email Override possible for all users Dec 21, 2019
@auto-label auto-label bot added the fix label Dec 21, 2019
@kushthedude
Copy link
Member Author

@mariobehling @iamareebjamal Please merge, Tested for Owner, Organiser, System Admin. No one except them can see this option now.

@kushthedude kushthedude requested review from iamareebjamal, mariobehling and prateekj117 and removed request for iamareebjamal December 21, 2019 16:42
@kushthedude
Copy link
Member Author

@iamareebjamal Please review & merge

@iamareebjamal
Copy link
Member

@prateekj117 Please test this

@iamareebjamal iamareebjamal merged commit d8420a3 into fossasia:development Dec 22, 2019
@kushthedude kushthedude deleted the spea branch January 2, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@mariobehling mariobehling Awaiting requested review from mariobehling

@prateekj117 prateekj117 Awaiting requested review from prateekj117

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call for Speakers Signup Form: "Don't require this email" possible for everyone
2 participants
@kushthedude @iamareebjamal