Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: appname for mobile screen #3715

Merged
merged 2 commits into from
Dec 22, 2019
Merged

fix: appname for mobile screen #3715

merged 2 commits into from
Dec 22, 2019

Conversation

himanshu010
Copy link
Member

Fixes #3620

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@himanshu010 himanshu010 mentioned this pull request Dec 22, 2019
Closed
5 tasks
@kushthedude
Copy link
Member

Please change the PR title as per Semantic Naming

@himanshu010 himanshu010 changed the title Update nav-bar.hbs Changing appname for mobile screens. Dec 22, 2019
@himanshu010
Copy link
Member Author

Please change the PR title as per Semantic Naming

@kushthedude done.

@snitin315
Copy link
Member

@himanshu010 , rewrite changing to fix:

@himanshu010 himanshu010 changed the title Changing appname for mobile screens. fix: appname for mobile screens. Dec 22, 2019
@auto-label auto-label bot added the fix label Dec 22, 2019
@iamareebjamal iamareebjamal changed the title fix: appname for mobile screens. fix: appname for mobile screen Dec 22, 2019
@iamareebjamal iamareebjamal merged commit dd4a997 into fossasia:development Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@kushthedude kushthedude kushthedude approved these changes

@iamareebjamal iamareebjamal Awaiting requested review from iamareebjamal

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some things are not visible on small screen
4 participants
@himanshu010 @kushthedude @snitin315 @iamareebjamal