chore: Migrate admin,account to ES6 in app/controllers

[kushthedude]

Refers #3618

Short description of what this resolves:

• Migrating the Controllers of Admin,Account section to ES6 syntax

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[kushthedude]

@iamareebjamal Tested complete admin section with all function.
Please have a look and merge.

[iamareebjamal]

Why not using codemods to automatically do this change rather than manually doing this repetitive task?

[kushthedude]

I did try some of the codemods, but they broke almost each action since ember community is small, none of those were compatible. There is one codemod for ember but ultimately it again requires a manual overlook for checking the breakage of computed property.

…

On Sun, 22 Dec, 2019, 21:23 Areeb Jamal, ***@***.***> wrote: Why not using codemods to automatically do this change rather than manually doing this repetitive task? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3716?email_source=notifications&email_token=AKQMTLS54X4NUZZUP3JB6JDQZ6ERLA5CNFSM4J6MIBPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPS6BA#issuecomment-568274692>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLWXKX3OJUQJHQJ5G6DQZ6ERLANCNFSM4J6MIBPA> .

[iamareebjamal]

I'm talking about from ember-cli-update

[kushthedude]

I think it was used when the app was updated to 3.10 in summers. It still left many. I will try again if it was not used.

…

On Sun, 22 Dec, 2019, 21:37 Areeb Jamal, ***@***.***> wrote: I'm talking about from ember-cli-update — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3716?email_source=notifications&email_token=AKQMTLWG6JOF4ZRWNQFCYULQZ6GC5A5CNFSM4J6MIBPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHPTICY#issuecomment-568275979>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLUMX2SWJ6BZAOFE3TDQZ6GC5ANCNFSM4J6MIBPA> .

[kushthedude]

@iamareebjamal The following happens:

• CLI-Update codemods does not work on babel parser and is an experimental feature which runs only ondecorators-legacy.
• Also, The codemods always skips the main files :

Also, the codemods changed the hbs files rather than going to js, I don't know why:-

Hence doing it manually.

[iamareebjamal]

For me, it changed the js files and hbs files both. hbs files need to be changed as well to glimmer syntax for octane

[kushthedude]

For me, it changed the js files and hbs files both. hbs files need to be changed as well to glimmer syntax for octane

Can you please push the js files it changes?

[iamareebjamal]

It was a quick test. But basically converts old syntax to new ES6 syntax, getters, decorators etc

[kushthedude]

It was a quick test. But basically converts old syntax to new ES6 syntax, getters, decorators etc

It just changes the js files in tests directory and none others

[iamareebjamal]

Not true

[iamareebjamal]

I ran

ember update
ember update --run-codemods

[kushthedude]

ember update --run-codemods

Let me try I was doing with ember-cli-update as I installed it globally

[iamareebjamal]

That command is installed with ember-cli-update only

[kushthedude]

That command is installed with ember-cli-update only

Again not successful, Also it broke the complete build.

[iamareebjamal]

it broke the complete build

That is expected