Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Place unverified user message above the segment in account route #3792

Merged
merged 2 commits into from
Jan 16, 2020
Merged

fix: Place unverified user message above the segment in account route #3792

merged 2 commits into from
Jan 16, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #3787
Screenshot from 2020-01-11 12-24-22

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@kushthedude
Copy link
Member

LGTM, Squash the commits.

@maze-runnar
Unverified User Message should be above the segment in account route
52803e6 
Unverified User Message should be above the segment in `account route`
@iamareebjamal iamareebjamal changed the title enh: Unverified User Message should be above the segment in account route fix: Unverified User Message should be above the segment in account route Jan 16, 2020
@auto-label auto-label bot added the fix label Jan 16, 2020
@iamareebjamal iamareebjamal changed the title fix: Unverified User Message should be above the segment in account route fix: Place unverified user message above the segment in account route Jan 16, 2020
@iamareebjamal iamareebjamal merged commit 7110e11 into fossasia:development Jan 16, 2020
@maze-runnar maze-runnar deleted the patch-23 branch January 16, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@kushthedude kushthedude kushthedude approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
enhancement fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Message: Unverified User Message should be above the segment in account route
4 participants
@maze-runnar @kushthedude @iamareebjamal @snitin315