-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make country as dropdown and add validation for gender #3809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maze-runnar have you checked if the country and gender values are getting saved ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for attendee country change type from text
to select
in custom-form.js mixin
this is a seperate isuue #3406 . |
Change the value as suggested by @snitin115 |
done 👍 |
A working gif with showing country field is getting saved? |
@kushthedude it's not saving like gender field, as mentioned in issue #3406. |
It is saving just not rendering, also part of same issue, involves same changes. |
@kushthedude here is full flow of attendee please take a look : https://youtu.be/o3uhEUdhl_8 |
Add fixes #3406 in your description as well |
Squash the commits, and provide a final GIF showing all these changes in action. |
in attendee list changing `enter` to `select` in validation prompt adding validation for gender changing country type to select render select type fields in attendee-list and make country as a drop-down
@kushthedude this is final video after all changes : https://youtu.be/o3uhEUdhl_8 |
@iamareebjamal There will be a need for migration in server side, As we have moved on from text to select in Country Field of Attendee dropdown ? |
Yes |
@maze-runnar Please make a migration for same |
@kushthedude can you please do it for me on server side 🙏 |
To be merged after fossasia/open-event-server#6746 |
Could I search the countries before? Using autocomplete? |
I dont understand |
Fixes: #3806
Fixes: #3780
Fixes: #3406
Short description of what this resolves:
In the attendee form validation for gender field was not working so i added it's validation identifier in
gender
field.The second issue was to make country field as drop-down, as it was text before.i added validation for it too. Also refactor the code little for readibility.
2 - when gender field is not required -
3 - country drop-down with flags -
4 - validate gender when required and not given with country -
Checklist
development
branch.