Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing secret from FE #3841

Merged
merged 1 commit into from
Jan 23, 2020
Merged

fix: Removing secret from FE #3841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions app/components/forms/admin/settings/system-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,20 +214,6 @@ export default Component.extend(FormMixin, {
prompt : this.l10n.t('Please enter the token for Sendgrid')
}
]
},

secretKey: {
identifier : 'secret_key',
rules : [
{
type : 'empty',
prompt : this.l10n.t('Please enter the application secret key')
},
{
type : 'minLength[16]',
prompt : this.l10n.t('Your application secret key must have at least {ruleValue} characters')
}
]
}
}
};
Expand Down
1 change: 0 additions & 1 deletion app/models/setting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export default ModelBase.extend({
appName : attr('string'),
orderExpiryTime : attr('number', { defaultValue: 15 }),
tagline : attr('string'),
secret : attr('string'),
storagePlace : attr('string'),
awsKey : attr('string'),
awsSecret : attr('string'),
Expand Down
13 changes: 0 additions & 13 deletions app/templates/components/forms/admin/settings/system-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,6 @@
<div class="ui hidden divider"></div>
{{forms/admin/settings/system/order-expiry-form settings=settings}}
<div class="ui hidden divider"></div>
<h3 class="ui header">
{{t 'App secret key'}}
<div class="sub header">
{{t 'Secret key for the application. Recommended is a random string of minimum 20 characters in length.'}}
</div>
</h3>
<div class="field">
<label>
{{t 'Secret'}}
</label>
{{input type='text' name='secret_key' value=settings.secret}}
</div>
<div class="ui hidden divider"></div>
<button class="ui teal wide button" type="submit">
{{t 'Save'}}
</button>
Expand Down