-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removing ember-scroll-to addon #3852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushthedude So we have to write actions manually if we want to use |
Can you check if this is the only place where we are using scroll to?
…On Mon, 27 Jan, 2020, 20:15 Nitin Kumar, ***@***.***> wrote:
#3562 (comment)
<#3562 (comment)>
@kushthedude <https://github.com/kushthedude>
I have gone through scroll-to docs , it doesn't provide much
functionality.
[image: Screenshot from 2020-01-27 20-11-57]
<https://user-images.githubusercontent.com/46647141/73183962-aaa76c00-4141-11ea-9285-4130b2920ff0.png>
So we have to write actions manually if we want to use scroll-to
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3852?email_source=notifications&email_token=AKQMTLWWLC2CBT7Y46VG5W3Q73XP5A5CNFSM4KLUXBWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7YF4Y#issuecomment-578781939>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLREEPCQM4NGODYO7M3Q73XP5ANCNFSM4KLUXBWA>
.
|
Yes It's the only place . |
Since we are only using the scroll property from the following add-on . |
Yes , I can give it a try. |
@snitin315 Update it |
Codecov Report
@@ Coverage Diff @@
## development #3852 +/- ##
============================================
Coverage 21.82% 21.82%
============================================
Files 460 460
Lines 4737 4737
============================================
Hits 1034 1034
Misses 3703 3703 Continue to review full report at Codecov.
|
a86780e
to
9167a1a
Compare
@iamareebjamal removed jQuery 👍 |
Fixes #2544
Refers #3704
Changes proposed in this pull request:
Preview link - https://deploy-preview-3852--open-event-fe.netlify.com/e/93efcaec
Checklist
development
branch.