Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing ember-scroll-to addon #3852

Merged
merged 4 commits into from
Feb 7, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jan 26, 2020

Fixes #2544
Refers #3704

Changes proposed in this pull request:

Preview link - https://deploy-preview-3852--open-event-fe.netlify.com/e/93efcaec

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jan 26, 2020
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315
Copy link
Member Author

#3562 (comment)

@kushthedude
I have gone through scroll-to docs , it doesn't provide much functionality.

Screenshot from 2020-01-27 20-11-57

So we have to write actions manually if we want to use scroll-to

@kushthedude
Copy link
Member

kushthedude commented Jan 27, 2020 via email

@snitin315
Copy link
Member Author

snitin315 commented Jan 27, 2020

Yes It's the only place .

@kushthedude
Copy link
Member

Since we are only using the scroll property from the following add-on .
Do you think you would be able to write custom action for scrolling by taking reference from here https://github.com/akshay-kr/ember-scroll-to-target/blob/master/addon/components/scroll-to.js ?
Scrolling is quite a simple property we should eliminate the add-on, if we can .

@snitin315
Copy link
Member Author

Do you think you would be able to write custom action for scrolling by taking reference from here https://github.com/akshay-kr/ember-scroll-to-target/blob/master/addon/components/scroll-to.js ?

Yes , I can give it a try.

@snitin315
Copy link
Member Author

@kushthedude
Copy link
Member

@snitin315 Update it

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #3852 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3852   +/-   ##
============================================
  Coverage        21.82%   21.82%           
============================================
  Files              460      460           
  Lines             4737     4737           
============================================
  Hits              1034     1034           
  Misses            3703     3703

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a984ac7...238b488. Read the comment docs.

@snitin315 snitin315 force-pushed the side-menu branch 2 times, most recently from a86780e to 9167a1a Compare February 6, 2020 15:05
@snitin315
Copy link
Member Author

@iamareebjamal removed jQuery 👍

@kushthedude kushthedude changed the title fix: target name gets highlited in side-menu fix: Removing ember-scroll-to addon Feb 7, 2020
@kushthedude kushthedude merged commit 3a8d169 into fossasia:development Feb 7, 2020
@snitin315 snitin315 deleted the side-menu branch February 7, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When scrolling to a target , The target name should get highlighted .
3 participants