Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @ember/jquery from 0.6.0 to 1.1.0 #3865

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 26, 2020

Bumps @ember/jquery from 0.6.0 to 1.1.0.

Release notes

Sourced from @ember/jquery's releases.

Release 1.1.0

🚀 Enhancement

  • #153 Add missing deprecation message for this.$() (@Turbo87)

Committers: 3

Release 1.0.0

💥 Breaking Change

🚀 Enhancement

  • #148 Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. (@lupestro)

📝 Documentation

Committers: 4

Release 0.6.1

🐛 Bug Fix

Committers: 1

Changelog

Sourced from @ember/jquery's changelog.

v1.1.0 (2019-10-04)

🚀 Enhancement

  • #153 Add missing deprecation message for this.$() (@Turbo87)

Committers: 3

v1.0.0 (2019-10-02)

💥 Breaking Change

🚀 Enhancement

  • #148 Allow addon to provide jQuery to final build, but not include Ember <-> jQuery integration. (@lupestro)

📝 Documentation

Committers: 4

v0.6.1 (2019-06-06)

🐛 Bug Fix

Committers: 1

Commits
  • 9112702 Release 1.1.0
  • c88dbf1 Add missing deprecation message for this.$() (#153)
  • dd96dd5 Remove noDeprecations tests
  • cade173 Add missing deprecation message for this.$()
  • 52886ad Merge pull request #152 from emberjs/dependabot/npm_and_yarn/ember-cli-htmlba...
  • 7a533b7 Bump ember-cli-htmlbars from 4.0.3 to 4.0.4
  • 32d79c3 Re-roll yarn.lock to avoid issues with missing integrity in yarn… (#151)
  • 4969158 Re-roll yarn.lock to avoid issues with missing integrity in yarn 1.19.0
  • 0a6391d Bump eslint-plugin-node from 9.2.0 to 10.0.0 (#133)
  • 07d66b4 Merge pull request #138 from emberjs/dependabot/npm_and_yarn/ember/optional-f...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 26, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch 2 times, most recently from b671796 to a448881 Compare January 26, 2020 18:03
@kushthedude
Copy link
Member

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@kushthedude
Copy link
Member

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch 4 times, most recently from 7622ecb to 56d0f4b Compare January 28, 2020 22:21
@kushthedude
Copy link
Member

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch from 56d0f4b to b0d0726 Compare January 29, 2020 04:01
@iamareebjamal
Copy link
Member

This is seriously so bad. It is showing the same deprecation message from same line of code 1000 times in a single test. Tests will never pass this way. @kushthedude Please disable ember-views.curly-components.jquery-element. It is impossible to work with

@iamareebjamal
Copy link
Member

TryGhost/Ghost#10651

@kushthedude
Copy link
Member

kushthedude commented Jan 29, 2020 via email

@iamareebjamal
Copy link
Member

We will move to native. But we can't fix the deprecations in 3rd party packages. It is not wise to show deprecations of other libraries mixed with our code. I can only be responsible for my code. Show me deprecations in open-event-frontend, I'll fix it. Why should my builds fail due to deprecations in ember-semantic-ui? Makes no sense to me. If there was an option to disable warnings of just 3rd party packages, then it would have been best. But here, it showing the deprecation of same like of code 1000 times in a single test

@iamareebjamal
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch from b0d0726 to 732a921 Compare January 29, 2020 10:18
@kushthedude
Copy link
Member

Would suppresing warnings in ember-semantic-ui will solve this issue ? @iamareebjamal

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@kushthedude kushthedude reopened this Jan 29, 2020
@kushthedude
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch from 732a921 to 869626c Compare January 29, 2020 10:41
@iamareebjamal
Copy link
Member

iamareebjamal commented Jan 29, 2020

Which issue? i'm talking about any 3rd party package in general and not just semantic-ui

@iamareebjamal iamareebjamal merged commit c7a0057 into development Jan 29, 2020
@iamareebjamal iamareebjamal deleted the dependabot/npm_and_yarn/ember/jquery-1.1.0 branch January 29, 2020 11:02
@kushthedude
Copy link
Member

Which issue? i'm talking about any 3rd party package in general and not just semantic-ui

Cool, If the issue is mainly because semantic-ui, I can look into it. But if it is general then we need to wait for add-ons to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants