-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump @ember/jquery from 0.6.0 to 1.1.0 #3865
chore(deps-dev): bump @ember/jquery from 0.6.0 to 1.1.0 #3865
Conversation
b671796
to
a448881
Compare
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
7622ecb
to
56d0f4b
Compare
@dependabot recreate |
56d0f4b
to
b0d0726
Compare
This is seriously so bad. It is showing the same deprecation message from same line of code 1000 times in a single test. Tests will never pass this way. @kushthedude Please disable |
I suggested the same earlier, but the idea was to move towards to native
jquery. But now this is the more feasible solution .
…On Wed, 29 Jan, 2020, 13:03 Areeb Jamal, ***@***.***> wrote:
TryGhost/Ghost#10651 <TryGhost/Ghost#10651>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3865?email_source=notifications&email_token=AKQMTLXQIBNGBL2LNL2LBETRAEWK7A5CNFSM4KLX6GE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKGHS7A#issuecomment-579631484>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXBF7II7PINYEGNNOTRAEWK7ANCNFSM4KLX6GEQ>
.
|
We will move to native. But we can't fix the deprecations in 3rd party packages. It is not wise to show deprecations of other libraries mixed with our code. I can only be responsible for my code. Show me deprecations in open-event-frontend, I'll fix it. Why should my builds fail due to deprecations in ember-semantic-ui? Makes no sense to me. If there was an option to disable warnings of just 3rd party packages, then it would have been best. But here, it showing the deprecation of same like of code 1000 times in a single test |
@dependabot rebase |
b0d0726
to
732a921
Compare
Would suppresing warnings in ember-semantic-ui will solve this issue ? @iamareebjamal |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@dependabot rebase |
Bumps [@ember/jquery](https://github.com/emberjs/ember-jquery) from 0.6.0 to 1.1.0. - [Release notes](https://github.com/emberjs/ember-jquery/releases) - [Changelog](https://github.com/emberjs/ember-jquery/blob/master/CHANGELOG.md) - [Commits](emberjs/ember-jquery@v0.6.0...v1.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
732a921
to
869626c
Compare
Which issue? i'm talking about any 3rd party package in general and not just semantic-ui |
Cool, If the issue is mainly because semantic-ui, I can look into it. But if it is general then we need to wait for add-ons to be updated. |
Bumps @ember/jquery from 0.6.0 to 1.1.0.
Release notes
Sourced from @ember/jquery's releases.
Changelog
Sourced from @ember/jquery's changelog.
Commits
9112702
Release 1.1.0c88dbf1
Add missing deprecation message forthis.$()
(#153)dd96dd5
RemovenoDeprecations
testscade173
Add missing deprecation message forthis.$()
52886ad
Merge pull request #152 from emberjs/dependabot/npm_and_yarn/ember-cli-htmlba...7a533b7
Bump ember-cli-htmlbars from 4.0.3 to 4.0.432d79c3
Re-roll yarn.lock to avoid issues with missing integrity in yarn… (#151)4969158
Re-roll yarn.lock to avoid issues with missing integrity in yarn 1.19.00a6391d
Bump eslint-plugin-node from 9.2.0 to 10.0.0 (#133)07d66b4
Merge pull request #138 from emberjs/dependabot/npm_and_yarn/ember/optional-f...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: