Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FE check for user-role #3928

Merged
merged 8 commits into from
Feb 1, 2020
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jan 31, 2020

Fixes #3927

Changes proposed in this pull request:

Screenshot from 2020-01-31 18-24-45

@auto-label auto-label bot added the fix label Jan 31, 2020
@snitin315 snitin315 changed the title fix: FE check for user-role fix: FE check for user-role [WIP] Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #3928 into development will decrease coverage by 0.04%.
The diff coverage is 77.77%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3928      +/-   ##
===============================================
- Coverage        21.98%   21.93%   -0.05%     
===============================================
  Files              460      460              
  Lines             4727     4728       +1     
===============================================
- Hits              1039     1037       -2     
- Misses            3688     3691       +3
Impacted Files Coverage Δ
app/controllers/register.js 27.58% <ø> (ø) ⬆️
app/services/loader.js 40% <ø> (ø) ⬆️
app/services/l10n.js 53.84% <ø> (ø) ⬆️
app/controllers/oauth/callback.js 0% <ø> (ø) ⬆️
app/components/account/application-section.js 0% <ø> (ø) ⬆️
app/controllers/public/index.js 0% <0%> (ø) ⬆️
app/components/forms/login-form.js 62.06% <100%> (ø) ⬆️
app/router.js 100% <100%> (ø) ⬆️
app/services/auth-manager.js 51.78% <0%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4cd02e...3d39b4f. Read the comment docs.

@snitin315 snitin315 changed the title fix: FE check for user-role [WIP] fix: FE check for user-role Jan 31, 2020
@snitin315 snitin315 requested a review from kushthedude January 31, 2020 15:22
@kushthedude kushthedude merged commit a4ddbb8 into fossasia:development Feb 1, 2020
@snitin315 snitin315 deleted the user-role branch February 5, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: FE check for user role is not working.
2 participants