Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: center aligned infinity loader spinner on public speaker page #3995

Merged
merged 2 commits into from
Feb 5, 2020
Merged

fix: center aligned infinity loader spinner on public speaker page #3995

merged 2 commits into from
Feb 5, 2020

Conversation

snitin315
Copy link
Member

Fixes #3991

@auto-label auto-label bot added the fix label Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #3995 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3995   +/-   ##
============================================
  Coverage        21.83%   21.83%           
============================================
  Files              460      460           
  Lines             4726     4726           
============================================
  Hits              1032     1032           
  Misses            3694     3694

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7c7e9...30938a4. Read the comment docs.

@kushthedude
Copy link
Member

Any gif will be appeciated

@snitin315
Copy link
Member Author

snitin315 commented Feb 4, 2020 •
edited
Loading

@kushthedude GIF for changes -

spinner

@snitin315 snitin315 requested a review from kushthedude February 4, 2020 13:50
kushthedude
kushthedude suggested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@kushthedude kushthedude left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't request reviews on PRs which have failing tests.

@snitin315
Copy link
Member Author

@kushthedude all checks have passed now.

@kushthedude kushthedude merged commit 457e877 into fossasia:development Feb 5, 2020
@snitin315 snitin315 deleted the infinity branch February 11, 2020 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinity Loader Spinner is not centre aligned
2 participants
@snitin315 @kushthedude