Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove location check from event-wizard mixin #4059

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

snitin315
Copy link
Member

Fixes #4058

Now Events can be saved as draft without filling the location field.

@auto-label auto-label bot added the fix label Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@5297b05). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4059   +/-   ##
==============================================
  Coverage               ?   21.89%           
==============================================
  Files                  ?      460           
  Lines                  ?     4736           
  Branches               ?        0           
==============================================
  Hits                   ?     1037           
  Misses                 ?     3699           
  Partials               ?        0
Impacted Files Coverage Δ
app/serializers/event.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5297b05...c8d1fec. Read the comment docs.

@iamareebjamal
Copy link
Member

And can the event be published without location?

@snitin315
Copy link
Member Author

And can the event be published without location?

@iamareebjamal No.

@kushthedude
Copy link
Member

And can the event be published without location?

Event should not be published without location, But it should be able to get saved as a draft if location is not mandatory according to #2602 (comment). This FE check was forcing the client to give location before saving as draft too.

@iamareebjamal iamareebjamal merged commit 747f7aa into fossasia:development Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Details Step: can not save event as draft without filling location field.
3 participants