Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix relative import #4096

Merged
merged 6 commits into from
Feb 15, 2020
Merged

chore: fix relative import #4096

merged 6 commits into from
Feb 15, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #4015

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Feb 15, 2020
@maze-runnar maze-runnar requested review from kushthedude and uds5501 and removed request for kushthedude and uds5501 February 15, 2020 16:08
@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #4096 into development will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4096   +/-   ##
============================================
  Coverage        21.88%   21.88%           
============================================
  Files              451      451           
  Lines             4729     4729           
============================================
  Hits              1035     1035           
  Misses            3694     3694

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f93f06...84a7306. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: fixed relative import chore: fixed relative import Feb 15, 2020
@auto-label auto-label bot added chore and removed fix labels Feb 15, 2020
@iamareebjamal iamareebjamal changed the title chore: fixed relative import chore: fix relative import Feb 15, 2020
@iamareebjamal iamareebjamal merged commit 4e66a53 into fossasia:development Feb 15, 2020
kushthedude
kushthedude reviewed Feb 15, 2020
View reviewed changes
app/initializers/extensions.js
@@ -1,4 +1,4 @@
import '../extensions/ember-table/component';
import 'open-event-frontend/extensions/ember-table/component';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure there should not be initialisers before the extension in here @maze-runnar ?

@iamareebjamal iamareebjamal mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushthedude kushthedude kushthedude left review comments

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@uds5501 uds5501 Awaiting requested review from uds5501

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maze-runnar @niranjan94 @iamareebjamal @kushthedude