fix: added .vscode and .nvmrc in .gitignore #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #4111 +/- ##
============================================
Coverage 21.88% 21.88%
============================================
Files 451 451
Lines 4729 4729
============================================
Hits 1035 1035
Misses 3694 3694Continue to review full report at Codecov.
|
|
From next time please avoid micro-PRs. Bundle micro-PRs into a bigger one. We want to ensure that devs who review PRs use their time efficiently. |
kushthedude
reviewed
Feb 17, 2020
| @@ -21,7 +21,7 @@ testem.log | |||
| /kubernetes/images/frontend/node_Modules/ | |||
| .env | |||
| .idea | |||
|
|
|||
|
Follow Semantic PR naming. |
|
Add both entries in a single PR |
adrijshikhar
changed the title
iamareebjamal
previously approved these changes
Feb 18, 2020
iamareebjamal
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
added .vscode in .gitignore
Checklist
developmentbranch.