fix: Removed bower

[Dishebh]

Fixes #3957

Short description of what this resolves:

Migrating away from bower to yarn.

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/33m3bdrxh
✅ Preview: https://open-event-frontend-git-fork-dishebh-removebower.eventyay.now.sh

[iamareebjamal]

There should be no reference of bower_components in the project

[iamareebjamal]

RC

[codecov]

Codecov Report

Merging #4235 into development will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #4235   +/-   ##
============================================
  Coverage        21.88%   21.88%           
============================================
  Files              461      461           
  Lines             4830     4830           
  Branches             5        5           
============================================
  Hits              1057     1057           
  Misses            3771     3771           
  Partials             2        2           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2899022...e605687. Read the comment docs.

[Dishebh]

There should be no reference of bower_components in the project

I guess I have changed bower_components to node_modules/@bower_components at all the places. Pls let me know if some place is left out.

[iamareebjamal]

I can see bower in node_modules/@bower_components. Ctrl+F and search bower in the project. Stop when the search returns 0 results

[iamareebjamal]

You should always look at unapproved PRs to first check what not to do, so you don't waste your time repeating the same things which another person did already - #3982

[Dishebh]

I can see bower in node_modules/@bower_components. Ctrl+F and search bower in the project. Stop when the search returns 0 results

I can see bower in node_modules/@bower_components. Ctrl+F and search bower in the project. Stop when the search returns 0 results

To migrate away from bower and switch to yarn, i.e., to bower-away all the dependencies from bower.json to package.json, isn't it necessary to change any reference to bower_components with node_modules/@bower_components, as mentioned in the link below?

https://bower.io/blog/2017/how-to-migrate-away-from-bower/

[iamareebjamal]

You need to remove bower components and use npm/yarn dependencies instead

[iamareebjamal]

See how it was done for raven JS #4091

[Dishebh]

You need to remove bower components and use npm/yarn dependencies instead

There's no bower.json file in the project, and removed bower_components from the project directory. But, since yarn is unable to resolve all the bower dependencies, so that's why adding those flattened to package.json. Hence, node_modules/@bower_components is necessary, as when we install package.json with yarn, node_modules/@bower_components will contain all components in exactly the same way they would be installed by Bower.

[Dishebh]

If you say, shall I try removing all the code lines containing node_modules/@bower_components as well, and see if the project is running without any additional warnings and errors?

[iamareebjamal]

It obviously won't work. You have to remove the bower component and add pure npm/yarn component. Tell me which component is not present in npm?

[Dishebh]

It obviously won't work. You have to remove the bower component and add pure npm/yarn component. Tell me which component is not present in npm?

But what shall I do about the SemanticUI sources present in environment.js file?

css : 'node_modules/@bower_components/open-event-theme/dist', javascript : 'node_modules/@bower_components/open-event-theme/dist', images : 'node_modules/@bower_components/open-event-theme/dist/themes/default/assets/images', fonts : 'node_modules/@bower_components/open-event-theme/dist/themes/default/assets/fonts'

They are all referring to bower_components in node_modules directory, each of which do not have any file or directory present on that path. Maybe, it is due to running bower-away.

[iamareebjamal]

Use the directory they are now installed in

[iamareebjamal]

If you want to make it easy on yourself. Remove one thing at a time and remove popular dependencies like croppie first

[Dishebh]

How about now?

[lgtm-com]

This pull request introduces 156 alerts when merging 5dd4bcf into 2899022 - view on LGTM.com

new alerts:

• 119 for Unused variable, import, function or class
• 16 for Useless assignment to local variable
• 10 for Unsafe jQuery plugin
• 4 for Useless conditional
• 4 for Comparison between inconvertible types
• 2 for Property access on null or undefined
• 1 for Superfluous trailing arguments

[iamareebjamal]

Seriously? You didn't see the 454 files you were about to commit before pushing?

[Dishebh]

Seriously? You didn't see the 454 files you were about to commit before pushing?

Honestly, what I just did was npm install all the bower dependencies, remove the @bower_components/node_modules dependencies from package.json, change the path of SemanticUI sources present in environment.js and ember-cli-build.js, and deleted the bower_components folder in the main directory. This, sure, caused a lot of file changes and additions.

[Dishebh]

Maybe, I will just try adding and replacing dependencies one-by-one as you said.