-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change components, routes, services, etc to native classes #4294
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/lsjv5cp0r |
This pull request introduces 1 alert when merging bbd0684 into 953d3a7 - view on LGTM.com new alerts:
|
app/routes/application.js
Outdated
|
||
sessionInvalidated() { | ||
if (!this.session.skipRedirectOnInvalidation) { | ||
this._super(...arguments); | ||
undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
This pull request introduces 1 alert when merging 39ba679 into 953d3a7 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 33b228a into 953d3a7 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 3a77a26 into 953d3a7 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to convert the mixins ?
Also in several functions, we have misused the computed property at our own will to not return any object, which needs to be fixed before going to classic. |
This is an automated conversion. All remaining things have to be converted by hand. Which include correcting things. Goal right now is to fix the build and get it merged |
This pull request introduces 1 alert when merging c8fbe2c into b13614f - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## development #4294 +/- ##
============================================
+ Coverage 21.86% 22.87% +1%
============================================
Files 461 468 +7
Lines 4835 4932 +97
Branches 5 5
============================================
+ Hits 1057 1128 +71
- Misses 3776 3802 +26
Partials 2 2
Continue to review full report at Codecov.
|
For #3714