Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change components, routes, services, etc to native classes #4294

Merged
merged 6 commits into from
Apr 5, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Mar 31, 2020

For #3714

@vercel vercel bot temporarily deployed to Preview March 31, 2020 01:22 Inactive
@vercel
Copy link

vercel bot commented Mar 31, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/lsjv5cp0r
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-native.eventyay.now.sh

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging bbd0684 into 953d3a7 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect


sessionInvalidated() {
if (!this.session.skipRedirectOnInvalidation) {
this._super(...arguments);
undefined;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging 39ba679 into 953d3a7 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging 33b228a into 953d3a7 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging 3a77a26 into 953d3a7 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to convert the mixins ?

@kushthedude
Copy link
Member

Also in several functions, we have misused the computed property at our own will to not return any object, which needs to be fixed before going to classic.

@iamareebjamal
Copy link
Member Author

This is an automated conversion. All remaining things have to be converted by hand. Which include correcting things. Goal right now is to fix the build and get it merged

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging c8fbe2c into b13614f - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@iamareebjamal iamareebjamal changed the title chore: Add @classic decorator on class Components chore: Change components, routes, services, etc to native classes Apr 5, 2020
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #4294 into development will increase coverage by 1%.
The diff coverage is 15.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4294   +/-   ##
============================================
+ Coverage        21.86%   22.87%   +1%     
============================================
  Files              461      468    +7     
  Lines             4835     4932   +97     
  Branches             5        5           
============================================
+ Hits              1057     1128   +71     
- Misses            3776     3802   +26     
  Partials             2        2
Impacted Files Coverage Δ
app/routes/admin/modules.js 0% <ø> (ø) ⬆️
app/routes/admin/reports/system-logs.js 0% <ø> (ø) ⬆️
app/routes/account/billing.js 100% <ø> (ø) ⬆️
app/controllers/events/view/index.js 0% <ø> (ø) ⬆️
app/controllers/admin/settings/billing.js 0% <ø> (ø) ⬆️
app/components/forms/user-payment-info-form.js 28.57% <ø> (ø) ⬆️
app/components/order-card.js 100% <ø> (ø) ⬆️
app/components/public/sponsor-list.js 100% <ø> (ø) ⬆️
app/components/forms/login-form.js 59.37% <ø> (ø) ⬆️
...ents/forms/admin/settings/system/storage-option.js 0% <ø> (ø) ⬆️
... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb82640...a3906bb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants