Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly format money everywhere #4428

Merged
merged 1 commit into from
May 31, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented May 31, 2020

For some reason, format-number was used to represent money in the app which removed any decimal part and rounded it off to integer

Before:
image

After:
image

@vercel
Copy link

vercel bot commented May 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dciegda3b
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-format-money.eventyay.now.sh

@auto-label auto-label bot added the fix label May 31, 2020
@codecov
Copy link

codecov bot commented May 31, 2020

Codecov Report

Merging #4428 into development will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4428      +/-   ##
===============================================
+ Coverage        22.57%   22.58%   +0.01%     
===============================================
  Files              468      469       +1     
  Lines             4962     4963       +1     
  Branches             6        6              
===============================================
+ Hits              1120     1121       +1     
  Misses            3841     3841              
  Partials             1        1              
Impacted Files Coverage Δ
app/initializers/accounting.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e87e5b...c65d814. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 3b21764 into fossasia:development May 31, 2020
@iamareebjamal iamareebjamal deleted the format-money branch May 31, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant