Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show complex custom form values for attendee info #4548

Merged

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 12, 2020

Fixes #4519

Short description of what this resolves:

Complex custom form values was not visible in attendee information.

Changes proposed in this pull request:

Make complex custom form values visible by checking if that particular field is complex or not.
complex-field-value-visible

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 12, 2020
@vercel
Copy link

vercel bot commented Jul 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/g820gjf5f
✅ Preview: https://open-event-fronten-git-fork-haider8-complex-field-value-77cffe.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #4548 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4548   +/-   ##
============================================
  Coverage        22.26%   22.26%           
============================================
  Files              471      471           
  Lines             4962     4962           
  Branches             8        8           
============================================
  Hits              1105     1105           
  Misses            3856     3856           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f049ef...0c22ae7. Read the comment docs.

@Haider8
Copy link
Contributor Author

Haider8 commented Jul 12, 2020

@iamareebjamal Please review

@iamareebjamal iamareebjamal changed the title fix: Show complex custom form values for attendee info feat: Show complex custom form values for attendee info Jul 12, 2020
@iamareebjamal iamareebjamal merged commit d247456 into fossasia:development Jul 12, 2020
@auto-label auto-label bot added feature and removed fix labels Jul 12, 2020
@Haider8 Haider8 deleted the complex-field-value-visible branch July 12, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No custom form data showing on attendee ticket holder's information
2 participants