Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add speaker and session custom form input #4549

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 13, 2020

The duplication is so horrendous that it took me 3 days to figure out

@vercel
Copy link

vercel bot commented Jul 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/i7yk5qbhf
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-speaker-session-form.eventyay.vercel.app

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/models/attendee.js  2
- app/models/speaker.js  2
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #4549 into development will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4549      +/-   ##
===============================================
- Coverage        22.26%   22.21%   -0.05%     
===============================================
  Files              471      473       +2     
  Lines             4962     4973      +11     
  Branches             8        8              
===============================================
  Hits              1105     1105              
- Misses            3856     3867      +11     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/orders/order-form.js 0.00% <ø> (ø)
app/components/forms/session-speaker-form.js 0.00% <0.00%> (ø)
app/models/attendee.js 0.00% <0.00%> (ø)
app/models/session.js 11.11% <0.00%> (-3.18%) ⬇️
app/models/speaker.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d247456...f0e50b8. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 2e02ea4 into fossasia:development Jul 13, 2020
@iamareebjamal iamareebjamal deleted the speaker-session-form branch July 13, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants