Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve event dashboard top nav #4616

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Fixes #4592

Changes proposed in this pull request:

  • Show "View"
  • Open event link in new tab
  • Only show "Preview" for unpublished events

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9nkqev6o5
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-event-dashboard.eventyay.vercel.app

@vercel vercel bot temporarily deployed to Preview July 23, 2020 07:44 Inactive
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #4616 into development will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4616      +/-   ##
===============================================
+ Coverage        22.27%   22.69%   +0.42%     
===============================================
  Files              474      474              
  Lines             4988     4988              
  Branches             8        8              
===============================================
+ Hits              1111     1132      +21     
+ Misses            3876     3855      -21     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/event-card.js 70.00% <0.00%> (+10.00%) ⬆️
app/controllers/index.js 70.00% <0.00%> (+30.00%) ⬆️
app/models/event.js 53.84% <0.00%> (+30.76%) ⬆️
app/utils/internal.js 75.00% <0.00%> (+50.00%) ⬆️
app/mixins/custom-primary-key.js 50.00% <0.00%> (+50.00%) ⬆️
app/utils/string.js 100.00% <0.00%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba9b1a...a430e21. Read the comment docs.

@iamareebjamal
Copy link
Member

Please always add screenshots for UI changes

@snitin315
Copy link
Member Author

Here is the GIF -

event-nav

@iamareebjamal
Copy link
Member

@mariobehling I'm a bit confused if this is the expected result. Please check

@mariobehling
Copy link
Member

Yes, this is the expected result. View/Preview opens in new tab, right? Then please accept this PR.

@snitin315
Copy link
Member Author

Yes, this is the expected result. View/Preview opens in new tab, right? Then please accept this PR.

Yes, it opens in a new tab now.

@mariobehling
Copy link
Member

Good. There is a follow up issue here: #4621

@iamareebjamal iamareebjamal changed the title enh: improve event dashboard top nav feat: improve event dashboard top nav Jul 23, 2020
@auto-label auto-label bot added the feature label Jul 23, 2020
@iamareebjamal iamareebjamal merged commit 4962be2 into fossasia:development Jul 23, 2020
@snitin315 snitin315 deleted the fix/event-dashboard branch July 24, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard: Show "View" instead of "Preview" for Live Events, Delete "Copy" Feature
3 participants