New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more session states #4638

Merged

iamareebjamal merged 3 commits into fossasia:development from iamareebjamal:session-states

Jul 26, 2020

Member

iamareebjamal commented Jul 26, 2020 •

edited

Loading

Fixes #4522


          feat: Add more session states

096dc47

vercel bot commented Jul 26, 2020 •

edited

Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jxkbjuxp1
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-session-states.eventyay.vercel.app

vercel bot deployed to Preview

July 26, 2020 07:30

View deployment

auto-label bot added the feature label

iamareebjamal added the Work in Progress label


          finalize

8c6300b

vercel bot deployed to Preview

July 26, 2020 17:17

View deployment

iamareebjamal removed the Work in Progress label

codecov bot commented Jul 26, 2020 •

edited

Loading

Codecov Report

Merging #4638 into development will increase coverage by 0.17%.
The diff coverage is 12.00%.

@@               Coverage Diff               @@
##           development    #4638      +/-   ##
===============================================
+ Coverage        22.90%   23.07%   +0.17%     
===============================================
  Files              472      475       +3     
  Lines             4978     4954      -24     
  Branches             8        8              
===============================================
+ Hits              1140     1143       +3     
+ Misses            3837     3810      -27     
  Partials             1        1

Impacted Files	Coverage Δ
...omponents/forms/admin/content/social-links-form.js	`0.00% <ø> (ø)`
...ui-table/cell/events/view/sessions/cell-buttons.js	`0.00% <0.00%> (ø)`
...le/cell/events/view/sessions/cell-session-state.js	`0.00% <0.00%> (ø)`
app/controllers/admin/sessions/list.js	`0.00% <ø> (ø)`
app/controllers/events/view/sessions.js	`0.00% <0.00%> (ø)`
app/controllers/events/view/sessions/list.js	`0.00% <0.00%> (ø)`
app/routes/admin/sessions.js	`0.00% <0.00%> (ø)`
app/routes/admin/sessions/list.js	`0.00% <0.00%> (ø)`
app/routes/create.js	`100.00% <ø> (ø)`
app/routes/events/view/sessions/list.js	`3.84% <10.00%> (+3.84%)`	⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5227cb7...050c6a4. Read the comment docs.

050c6a4

vercel bot deployed to Preview

July 26, 2020 17:51

View deployment

iamareebjamal merged commit 1bb2d9a into fossasia:development

iamareebjamal deleted the session-states branch

July 26, 2020 17:52

Member

niranjan94 commented Jul 26, 2020

Here is an overview of what got changed by this pull request:

Issues
======
- Added 8
           

Complexity decreasing per file
==============================
+ app/routes/admin/sessions/list.js  -4

See the complete overview on Codacy

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+                accepted: 'teal',
+                confirmed: 'green',
+                pending: 'yellow',
+                rejected: 'red',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'rejected'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+                draft: 'grey',
+                accepted: 'teal',
+                confirmed: 'green',
+                pending: 'yellow',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'pending'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+                pending: 'yellow',
+                rejected: 'red',
+                deleted: 'red',
+                withdrawn: 'black',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'withdrawn'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+                confirmed: 'green',
+                pending: 'yellow',
+                rejected: 'red',
+                deleted: 'red',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'deleted'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

		@@ -0,0 +1,12 @@
		export const stateColorMap = {
		draft: 'grey',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'draft'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+              export const stateColorMap = {
+                draft: 'grey',
+                accepted: 'teal',
+                confirmed: 'green',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'confirmed'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

@@ @@ -0,0 +1,12 @@ @@
+              export const stateColorMap = {
+                draft: 'grey',
+                accepted: 'teal',

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'accepted'.

niranjan94 reviewed

View reviewed changes

app/utils/dictionary/sessions.ts

+                rejected: 'red',
+                deleted: 'red',
+                withdrawn: 'black',
+                canceled: 'orange'

Member

niranjan94 Jul 26, 2020

Codacy found an issue: Missing space after key 'canceled'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels