Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visibility of custom form field and info text color #4645

Merged
merged 5 commits into from
Jul 28, 2020
Merged

fix: visibility of custom form field and info text color #4645

merged 5 commits into from
Jul 28, 2020

Conversation

ruhci28
Copy link
Contributor

@ruhci28 ruhci28 commented Jul 27, 2020

Fixes #4607

Short description of what this resolves:

custom form field is visible even when the attendee form is turn off . Text under Information about attendee form is very light.

Changes proposed in this pull request:

-Make the Custom form field visible only when the attendee form is turn on .
-change the color of the text under Information about attendee form to make it more readable and visible.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [ x
    Screenshot 2020-07-27 at 10 06 48 PM
    Screenshot 2020-07-27 at 10 02 53 PM

I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/drolyymn5
✅ Preview: https://open-event-fronte-git-fork-ruhci28-attendeeformcustominp-da9fe0.eventyay.vercel.app

@customForms={{this.data.customForms}}
@event={{this.data.event}}
@form="attendee" />
{{/if}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add one more if and nor just move it inside the if above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@iamareebjamal
Copy link
Member

Also, please change the PR title to something proper

@ruhci28
Copy link
Contributor Author

ruhci28 commented Jul 28, 2020

Also, please change the PR title to something proper

Yeah sure.

@ruhci28 ruhci28 changed the title Attendee_form_custom_input_field fix:visibility of custom form field and change text color to make more readable Jul 28, 2020
@auto-label auto-label bot added the fix label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #4645 into development will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4645      +/-   ##
===============================================
+ Coverage        22.90%   23.08%   +0.18%     
===============================================
  Files              472      475       +3     
  Lines             4978     4952      -26     
  Branches             8        8              
===============================================
+ Hits              1140     1143       +3     
+ Misses            3837     3808      -29     
  Partials             1        1              
Impacted Files Coverage Δ
...omponents/forms/admin/content/social-links-form.js 0.00% <ø> (ø)
app/routes/create.js 100.00% <ø> (ø)
app/router.js 100.00% <0.00%> (ø)
app/routes/admin/sessions.js 0.00% <0.00%> (ø)
app/routes/admin/sessions/list.js 0.00% <0.00%> (ø)
app/controllers/admin/events/list.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/list.js 0.00% <0.00%> (ø)
app/controllers/admin/users/view/events/list.js 0.00% <0.00%> (ø)
app/controllers/my-sessions/view.js
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5227cb7...510d394. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix:visibility of custom form field and change text color to make more readable 0fix:visibility of custom form field and change text color to make more readable Jul 28, 2020
@iamareebjamal iamareebjamal changed the title 0fix:visibility of custom form field and change text color to make more readable fix: visibility of custom form field and change text color to make more readable Jul 28, 2020
@auto-label auto-label bot removed the fix label Jul 28, 2020
@iamareebjamal iamareebjamal changed the title fix: visibility of custom form field and change text color to make more readable fix: visibility of custom form field and info text color Jul 28, 2020
@auto-label auto-label bot added the fix label Jul 28, 2020
@iamareebjamal iamareebjamal merged commit 62fd18d into fossasia:development Jul 28, 2020
@ruhci28
Copy link
Contributor Author

ruhci28 commented Jul 28, 2020

Thanks @iamareebjamal 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants