-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: visibility of custom form field and info text color #4645
fix: visibility of custom form field and info text color #4645
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/drolyymn5 |
@customForms={{this.data.customForms}} | ||
@event={{this.data.event}} | ||
@form="attendee" /> | ||
{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add one more if and nor just move it inside the if above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Also, please change the PR title to something proper |
Yeah sure. |
Codecov Report
@@ Coverage Diff @@
## development #4645 +/- ##
===============================================
+ Coverage 22.90% 23.08% +0.18%
===============================================
Files 472 475 +3
Lines 4978 4952 -26
Branches 8 8
===============================================
+ Hits 1140 1143 +3
+ Misses 3837 3808 -29
Partials 1 1
Continue to review full report at Codecov.
|
Thanks @iamareebjamal 🙂 |
Fixes #4607
Short description of what this resolves:
custom form field is visible even when the attendee form is turn off . Text under Information about attendee form is very light.
Changes proposed in this pull request:
-Make the Custom form field visible only when the attendee form is turn on .
-change the color of the text under Information about attendee form to make it more readable and visible.
Checklist
development
branch.I have added necessary documentation (if appropriate)