Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement publish-unpublish pop up for mobile devices #4669

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Follow up #4655. Implement pop up confirmation for mobile devices as well.

Changes proposed in this pull request:

Before

bug-publish

After

fix-final-publish

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lq8qkzde0
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-publish-modal.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #4669 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4669   +/-   ##
============================================
  Coverage        23.03%   23.03%           
============================================
  Files              476      476           
  Lines             4962     4962           
  Branches             8        8           
============================================
  Hits              1143     1143           
  Misses            3818     3818           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7edbb...b48a042. Read the comment docs.

@iamareebjamal
Copy link
Member

Thanks

@iamareebjamal iamareebjamal merged commit e603810 into fossasia:development Jul 30, 2020
@snitin315 snitin315 deleted the fix/publish-modal branch July 30, 2020 10:27
@iamareebjamal
Copy link
Member

For #4621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants