Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additional info option #4677

Closed
wants to merge 3 commits into from
Closed

added additional info option #4677

wants to merge 3 commits into from

Conversation

himanshujaidka
Copy link
Contributor

@himanshujaidka himanshujaidka commented Jul 30, 2020

I have removed Links and Social Media
Listing Privacy
Add Code of Conduct
License of Event Data and Content and add it to new file inside wizard (additional-info-step.hbs)
and one file inside edit (aditional.hbs)

Fixes #4671

Short description of what this resolves:

I removed Links and Social Media
Listing Privacy
Add Code of Conduct
License of Event Data and Content all this from basic details

Changes proposed in this pull request:

-added new file inside wizard (additional-info-step.hbs)
-added new file inside edit (additional.hbs)

-but unable to put inside main contant

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

review my PR and tell me what to do next with it

I have removed Links and Social Media
Listing Privacy
Add Code of Conduct
License of Event Data and Content and add it to new file inside wizard (additional-info-step.hbs)
and one file inside edit (aditional.hbs)
@vercel
Copy link

vercel bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1sssyd6ha
✅ Preview: https://open-event-frontend-git-fork-himanshujaidka-development.eventyay.vercel.app

@vercel vercel bot temporarily deployed to Preview July 30, 2020 20:22 Inactive
@iamareebjamal
Copy link
Member

Please always add pictures/GIF for UI changes. And build is failing

@himanshujaidka
Copy link
Contributor Author

@iamareebjamal could you please tell me how I solve this build failure issue because I am new o open-source

@iamareebjamal
Copy link
Member

@mariobehling
Copy link
Member

Already fixed. Therefore closing it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard: Simplify UX by separating step 1 into two steps
4 participants