Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't expand ticket input when editing existing event #4679

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

Haider8
Copy link
Contributor

@Haider8 Haider8 commented Jul 30, 2020

Fixes #4672

Short description of what this resolves:

When editing existing events ticket input is in expanded state which is not needed.

Changes proposed in this pull request:

Don't expand ticket input when editing existing event. If event id already exists then there's no need to show expanded ticket input settings.

no-expand-when-edit

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 30, 2020
@vercel
Copy link

vercel bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jjxvujq5v
✅ Preview: https://open-event-frontend-git-fork-haider8-issue-4672.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #4679 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4679   +/-   ##
============================================
  Coverage        23.11%   23.11%           
============================================
  Files              476      476           
  Lines             4967     4967           
  Branches             8        8           
============================================
  Hits              1148     1148           
  Misses            3818     3818           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca1c75...0dee73b. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 567e879 into fossasia:development Jul 31, 2020
@Haider8 Haider8 deleted the issue-4672 branch July 31, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket Forms (Basic Details): All tickets are expanded when user edits "Basic Details"
2 participants