Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list speakers only with confirmed/accepted sessions #4828

Closed

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Fixes #4813

Changes proposed in this pull request:

only list speakers with confirmed/accepted sessions on the public speakers page

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests, and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/j1nopgxd8
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-speaker-session.eventyay.vercel.app

@auto-label auto-label bot added the fix label Aug 20, 2020
@snitin315 snitin315 changed the title fix: only list speakers with confirmed/accepted sessions fix: list speakers only with confirmed/accepted sessions Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #4828 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4828   +/-   ##
============================================
  Coverage        23.48%   23.48%           
============================================
  Files              481      481           
  Lines             5085     5085           
  Branches            16       16           
============================================
  Hits              1194     1194           
  Misses            3887     3887           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1763c2b...9c01201. Read the comment docs.

@iamareebjamal
Copy link
Member

That's not the correct fix. People with deleted sessions are being included. That's the bug. I have fixed it. Sending PR soon

@iamareebjamal
Copy link
Member

Superseded by #4830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Speaker Page: Speaker who does Not have session in speaker list
2 participants