Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct order of fields in payment-info form #4833

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Fixes #4670

Changes proposed in this pull request:

Screenshot at 2020-08-21 11-10-36

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests, and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5nnu155n9
✅ Preview: https://open-event-frontend-git-fork-snitin315-fix-payment-form.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #4833 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4833   +/-   ##
============================================
  Coverage        23.53%   23.53%           
============================================
  Files              481      481           
  Lines             5085     5085           
  Branches            16       16           
============================================
  Hits              1197     1197           
  Misses            3884     3884           
  Partials             4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4d641...65bee0f. Read the comment docs.

@iamareebjamal
Copy link
Member

Some points aren't complete

@snitin315
Copy link
Member Author

Fix Country dropdown. It automatically shows data saved in the browsers instead of using the dropdown country option

Will take care of this too.

@iamareebjamal iamareebjamal merged commit e67e366 into fossasia:development Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment Form: Billing Information Correct Sorting, do not make required and fix Country dropdown
2 participants