-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: page scroll with URL hash redirection. #4883
fix: page scroll with URL hash redirection. #4883
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3p2hesww1 |
Codecov Report
@@ Coverage Diff @@
## development #4883 +/- ##
===============================================
- Coverage 23.17% 23.14% -0.04%
===============================================
Files 481 481
Lines 5096 5103 +7
Branches 18 18
===============================================
Hits 1181 1181
- Misses 3911 3918 +7
Partials 4 4
Continue to review full report at Codecov.
|
@iamareebjamal please review. |
Thanks a lot for the fix and explanation. Will review soon and revert |
When I click on |
@iamareebjamal Now the URL hash updates with the anchor jumps. Please review. Demo:
The links are from the latest vercel deployment. |
super.didRender(); | ||
const anchor_tag = window.location.hash; | ||
$('html, body').animate({ | ||
scrollTop: $(anchor_tag).offset().top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing Cannot read property 'top' of undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, mostly
As mentioned, changes are throwing a lot of errors, hence reverting |
This reverts commit 594d156.
Fixes #4849
Short description of what this resolves:
Demo Links:
These links direct to the respective sections of the event page in the demo.
Checklist
development
branch.