enh: Adding verticle timeline to session page #4921

maze-runnar · 2020-08-31T17:14:26Z

Fixes #

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-08-31T17:14:32Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/4tcknvddr
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-7.eventyay.vercel.app

iamareebjamal · 2020-09-01T14:10:45Z

There shouldn't be any line breaks in time. See the example UI in meeting notes

maze-runnar · 2020-09-01T15:13:29Z

iamareebjamal · 2020-09-01T15:22:09Z

Now it's 12 hour time without AM/PM

maze-runnar · 2020-09-01T17:08:54Z

@iamareebjamal now it's showing 24 hour format, similar to website generate;

iamareebjamal · 2020-09-04T06:32:47Z

@maze-runnar The build is failing. Please finalize old issues before taking on new ones

codecov · 2020-09-04T09:30:58Z

Codecov Report

Merging #4921 into development will decrease coverage by 0.50%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #4921      +/-   ##
===============================================
- Coverage        23.22%   22.72%   -0.51%     
===============================================
  Files              481      485       +4     
  Lines             5098     5153      +55     
  Branches            18       21       +3     
===============================================
- Hits              1184     1171      -13     
- Misses            3910     3978      +68     
  Partials             4        4

Impacted Files	Coverage Δ
app/controllers/index.js	`36.36% <0.00%> (-54.55%)`	⬇️
app/utils/computed-helpers.js	`22.50% <0.00%> (-7.50%)`	⬇️
app/components/forms/wizard/basic-details-step.js	`18.57% <0.00%> (-5.82%)`	⬇️
app/components/widgets/forms/link-input.js	`42.10% <0.00%> (-5.27%)`	⬇️
app/components/forms/wizard/custom-form-input.ts	`4.16% <0.00%> (-4.17%)`	⬇️
app/components/schedule.ts	`62.22% <0.00%> (-3.64%)`	⬇️
app/routes/explore.js	`58.62% <0.00%> (-0.64%)`	⬇️
app/router.js	`100.00% <0.00%> (ø)`
app/mixins/event-wizard.js	`1.13% <0.00%> (ø)`
app/helpers/ui-grid-number.js	`34.78% <0.00%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93c224...aa69e8e. Read the comment docs.

maze-runnar · 2020-09-04T09:44:28Z

@maze-runnar The build is failing. Please finalize old issues before taking on new ones

Done

iamareebjamal · 2020-09-04T09:49:42Z

Thanks. I'll review it

iamareebjamal · 2020-09-07T08:26:07Z

app/templates/public/sessions.hbs

  {{#each this.model.session as |session|}}
-    <Public::SessionItem @session={{session}} @timezone={{this.timezone}} />
+    <li class="tl-item" ng-repeat="item in retailer_history">


Unnecessary code

@iamareebjamal I have removed unrequired code from css and hbs both.

mariobehling · 2020-09-07T10:20:00Z

We can improve the design at a later stage in detail, but for now at least the times should follow the spacing as the above design items. Please move the time to the right in order to follow an imaginary line from top to bottom (based on the headings above). Thanks.

iamareebjamal · 2020-09-07T10:24:29Z

@maze-runnar Please center align the time so that it looks better

maze-runnar · 2020-09-07T13:09:21Z

maze-runnar · 2020-09-07T13:13:33Z

iamareebjamal · 2020-09-07T13:27:49Z

Nothing has changed. Please reread the comments and picture

iamareebjamal · 2020-09-07T13:28:31Z

at least the times should follow the spacing as the above design items. Please move the time to the right in order to follow an imaginary line from top to bottom (based on the headings above). Thanks.

iamareebjamal · 2020-09-07T13:29:17Z

The time now seems even more left aligned. Even going as far as being aligned to the sidebar

maze-runnar · 2020-09-07T14:43:33Z

Nothing has changed. Please reread the comments and picture

the line should be in left & time should be in right?

iamareebjamal · 2020-09-07T15:23:55Z

Time should not be aligned to the left. See mario's image

maze-runnar · 2020-09-07T15:27:56Z

Time should not be aligned to the left. See mario's image

I am not exactly getting his image, what is trying to say.

iamareebjamal · 2020-09-07T15:47:21Z

The time is aligned to the left. It should move to the right

iamareebjamal · 2020-09-07T15:47:58Z

Not aligned to the right. It should move slightly to the right to match the margin on the rest of the content

iamareebjamal · 2020-09-07T15:49:03Z

@snitin315 Can you please explain if you understand?

maze-runnar · 2020-09-07T15:49:52Z

Not aligned to the right. It should move slightly to the right to match the margin on the rest of the content

ok, got it

snitin315 · 2020-09-07T15:52:09Z

Expected-

    Session
    10-11
    11-12

Current-

    Session
  10-11
  11-12

maze-runnar · 2020-09-07T16:23:03Z

I have deleted the fork due to some issue, and fork again the project, so creating a new PR for this with updated changes. #5002

maze-runnar added 2 commits August 31, 2020 22:39

adding verticle time line css

74d98a5

adding verticle timeline

a8d4c24

vercel bot temporarily deployed to Preview August 31, 2020 17:14 Inactive

Update track-item.scss

5290610

vercel bot temporarily deployed to Preview August 31, 2020 17:16 Inactive

Update track-item.scss

d71c4b8

vercel bot deployed to Preview August 31, 2020 17:17 View deployment

making timeline similar to schedule page

dbc729d

vercel bot deployed to Preview September 1, 2020 15:10 View deployment

updating time to 24 hour format

eaf603a

vercel bot deployed to Preview September 1, 2020 17:07 View deployment

fixing CI

3988010

vercel bot deployed to Preview September 4, 2020 08:52 View deployment

travis CI build fix

05c7f44

vercel bot deployed to Preview September 4, 2020 09:08 View deployment

last ever CI fix

0608be1

vercel bot deployed to Preview September 4, 2020 09:15 View deployment

iamareebjamal reviewed Sep 7, 2020

View reviewed changes

removing unrequired CSS

b843177

vercel bot temporarily deployed to Preview September 7, 2020 09:33 Inactive

removing unrequired

1f63361

vercel bot deployed to Preview September 7, 2020 09:33 View deployment

updating

76acc40

vercel bot temporarily deployed to Preview September 7, 2020 13:08 Inactive

changing margin-top to 15%, looking good

aa69e8e

vercel bot deployed to Preview September 7, 2020 13:11 View deployment

maze-runnar closed this Sep 7, 2020

maze-runnar mentioned this pull request Sep 7, 2020

feat: add verticle timeline #5002

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enh: Adding verticle timeline to session page #4921

enh: Adding verticle timeline to session page #4921

maze-runnar commented Aug 31, 2020

vercel bot commented Aug 31, 2020 •

edited

Loading

iamareebjamal commented Sep 1, 2020 •

edited

Loading

maze-runnar commented Sep 1, 2020

iamareebjamal commented Sep 1, 2020

maze-runnar commented Sep 1, 2020

iamareebjamal commented Sep 4, 2020

codecov bot commented Sep 4, 2020 •

edited

Loading

maze-runnar commented Sep 4, 2020

iamareebjamal commented Sep 4, 2020

iamareebjamal Sep 7, 2020

maze-runnar Sep 7, 2020

mariobehling commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

snitin315 commented Sep 7, 2020

maze-runnar commented Sep 7, 2020 •

edited

Loading

enh: Adding verticle timeline to session page #4921

enh: Adding verticle timeline to session page #4921

Conversation

maze-runnar commented Aug 31, 2020

Checklist

vercel bot commented Aug 31, 2020 • edited Loading

iamareebjamal commented Sep 1, 2020 • edited Loading

maze-runnar commented Sep 1, 2020

iamareebjamal commented Sep 1, 2020

maze-runnar commented Sep 1, 2020

iamareebjamal commented Sep 4, 2020

codecov bot commented Sep 4, 2020 • edited Loading

Codecov Report

maze-runnar commented Sep 4, 2020

iamareebjamal commented Sep 4, 2020

iamareebjamal Sep 7, 2020

Choose a reason for hiding this comment

maze-runnar Sep 7, 2020

Choose a reason for hiding this comment

mariobehling commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

iamareebjamal commented Sep 7, 2020

maze-runnar commented Sep 7, 2020

snitin315 commented Sep 7, 2020

maze-runnar commented Sep 7, 2020 • edited Loading

vercel bot commented Aug 31, 2020 •

edited

Loading

iamareebjamal commented Sep 1, 2020 •

edited

Loading

codecov bot commented Sep 4, 2020 •

edited

Loading

maze-runnar commented Sep 7, 2020 •

edited

Loading