Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement dropdown for social media in other-details step #4924

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

snitin315
Copy link
Member

Fixes #4610

Short description of what this resolves:

  • Offer a dropdown menu of all kinds of social media services and require the user to only fill in the user name.
  • Change the name "External Event URL" to "Website"

Changes proposed in this pull request:

captured

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ah1vqu13n
✅ Preview: https://open-event-frontend-git-fork-snitin315-feat-social-dpodown.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4924 into development will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4924      +/-   ##
===============================================
+ Coverage        22.85%   22.90%   +0.04%     
===============================================
  Files              483      483              
  Lines             5123     5125       +2     
  Branches            18       18              
===============================================
+ Hits              1171     1174       +3     
+ Misses            3948     3947       -1     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/forms/wizard/other-details-step.js 0.00% <ø> (ø)
app/components/widgets/forms/link-input.js 32.00% <0.00%> (-10.11%) ⬇️
app/utils/computed-helpers.js 21.95% <0.00%> (-0.55%) ⬇️
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcce5db...ca9e552. Read the comment docs.

@iamareebjamal
Copy link
Member

There shouldn't be a dropdown on the right field

@iamareebjamal
Copy link
Member

@snitin315 Please rebase as basic details step has been split into 2

@snitin315
Copy link
Member Author

Resolving conflicts 👍🏻

@snitin315 snitin315 changed the title feat: implement dropdown for social media in basic-details step feat: implement dropdown for social media in other-details step Sep 1, 2020
@snitin315
Copy link
Member Author

dropdown

@iamareebjamal
Copy link
Member

Great work

@iamareebjamal iamareebjamal merged commit e322851 into fossasia:development Sep 2, 2020
@snitin315 snitin315 deleted the feat/social-dpodown branch September 2, 2020 05:15
iamareebjamal added a commit to iamareebjamal/open-event-frontend that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Event Info External Links: Simplify Form by offering dropdown options
2 participants