Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit Custom Form Fields #4930

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 1, 2020

Fixes #4596

image

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dz8l0ph4w
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-edit-fields.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request introduces 1 alert when merging a511cc5 into a93c224 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4930 into development will decrease coverage by 0.04%.
The diff coverage is 5.55%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4930      +/-   ##
===============================================
- Coverage        22.85%   22.80%   -0.05%     
===============================================
  Files              484      485       +1     
  Lines             5133     5148      +15     
  Branches            18       21       +3     
===============================================
+ Hits              1173     1174       +1     
- Misses            3956     3970      +14     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/custom-form-input.ts 4.16% <0.00%> (-4.17%) ⬇️
app/routes/events/view/edit/attendee.js 0.00% <0.00%> (ø)
app/routes/events/view/edit/sessions-speakers.js 0.00% <ø> (ø)
app/components/forms/wizard/custom-forms/table.ts 50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98aed86...801154c. Read the comment docs.

@iamareebjamal iamareebjamal changed the title feat: Edit or Delete Custom Form Fields feat: Edit Custom Form Fields Sep 3, 2020
@iamareebjamal
Copy link
Member Author

Adding Editing only for now as deleting is more involved

@iamareebjamal iamareebjamal merged commit 6e67c93 into fossasia:development Sep 3, 2020
@iamareebjamal iamareebjamal deleted the edit-fields branch September 3, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove or delete custom question
1 participant